You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's been mentioned/requested multiple times on the internals thread that cargo fix should remove the extern crate statements when moving to Rust 2018.
Motivation
One of the big draws of Rust 2018's module system is that all of the "redundant" extern crate lines can finally be removed. It took some of the excitement away when I went through all of the cargo fix steps and still saw them there. I think it will just be a better experience for users to see one of the tangible benefits of this change. As it is right now, they just see the crate:: in front of all of their local imports and they might not realize what a nice change the module system updates really are.
After I manually removed the extern crate's I did get my satisfying result 😄, but let's give this to users on the first go around.
The text was updated successfully, but these errors were encountered:
Thanks for the report! Implementation-wise this will actually go into the compiler as we'll be tweaking the lint to do this, mind refiling the issue over there?
It's been mentioned/requested multiple times on the internals thread that
cargo fix
should remove theextern crate
statements when moving to Rust 2018.Motivation
One of the big draws of Rust 2018's module system is that all of the "redundant"
extern crate
lines can finally be removed. It took some of the excitement away when I went through all of thecargo fix
steps and still saw them there. I think it will just be a better experience for users to see one of the tangible benefits of this change. As it is right now, they just see thecrate::
in front of all of their local imports and they might not realize what a nice change the module system updates really are.After I manually removed the
extern crate
's I did get my satisfying result 😄, but let's give this to users on the first go around.The text was updated successfully, but these errors were encountered: