Skip to content

Introduce -Z flag to control how proc-macros are run #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 3 tasks
mystor opened this issue Jul 14, 2022 · 3 comments
Closed
1 of 3 tasks

Introduce -Z flag to control how proc-macros are run #528

mystor opened this issue Jul 14, 2022 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@mystor
Copy link

mystor commented Jul 14, 2022

Proposal

In rust-lang/rust#99123 I am hoping to add a new permanently-unstable -Zproc-macro-execution-strategy={same-thread,cross-thread} flag which can be used to control the way that proc-macros are run when expanding macros in the compiler.

This is being added as after recent changes in the bridge layer, which should have brought the performance of cross-thread execution much closer to same-thread execution than it was previously. Having a flag to change this behaviour without rebuilding rustc should be useful for real-world performance testing or comparison to see how practical a change to cross-thread or otherwise-isolated execution in the future.

Mentors or Reviewers

The patch has already been written by myself, and reviewed by @eddyb. It is a fairly simple change.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@mystor mystor added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Jul 14, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 14, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 14, 2022
@eddyb
Copy link
Member

eddyb commented Jul 14, 2022

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Jul 14, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 21, 2022
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 27, 2022
@eddyb eddyb mentioned this issue Jul 27, 2022
Merged
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eddyb @mystor @apiraino @rustbot