Commit 1691543
committed
Auto merge of #617 - Mark-Simulacrum:opt, r=Mark-Simulacrum
Wait for up to a second for existing database lock to clear
This lets users queue new builds and otherwise schedule work while an ongoing
run is proceeding (with lots of record-progress hits). Arguably we want to
prioritize user-initiated commands to take effect and cancel ongoing
record-progress operations (and other automated work), but that will need more
care.
Should fix cases like rust-lang/rust#94775 (comment),
or at least make them much more rare (individual database operations should very rarely take >1s,
though our logs do suggest it is not entirely infrequent today. (That's something that's worth looking into,
just haven't had time yet).
```
[2022-03-10T16:08:38Z DEBUG crater::db] sql query "INSERT INTO results (experiment, crate, toolchain, result, log, encoding) VALUES (?1, ?2, ?3, ?4, ?5, ?6);" executed in 5.009915144s
[2022-03-10T16:08:43Z DEBUG crater::db] sql query "INSERT INTO results (experiment, crate, toolchain, result, log, encoding) VALUES (?1, ?2, ?3, ?4, ?5, ?6);" executed in 5.009725792s
[2022-03-10T16:08:46Z DEBUG crater::db] sql query "INSERT INTO results (experiment, crate, toolchain, result, log, encoding) VALUES (?1, ?2, ?3, ?4, ?5, ?6);" executed in 3.235525973s
```1 file changed
+1
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
0 commit comments