Skip to content

FetchAdapter deprecation warning after recent frontend version bumps #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtgeibel opened this issue Dec 19, 2019 · 2 comments · Fixed by #2035
Closed

FetchAdapter deprecation warning after recent frontend version bumps #1995

jtgeibel opened this issue Dec 19, 2019 · 2 comments · Fixed by #2035

Comments

@jtgeibel
Copy link
Member

Current master is emitting the following warning one or more times for many of the tests.

WARN: DEPRECATION: FetchAdapter is deprecated, it is no longer required for ember-data>=3.9.2 [deprecation id: deprecate-fetch-ember-data-support]

It's confusing to me that ember-data>=3.9.2 is mentioned, when we are still on ember-data=2.18.2. (#1990 has already been opened to upgrade ember-data, but that PR is failing)

This warning appears to have been introduced in #1977. (See https://travis-ci.com/rust-lang/crates.io/jobs/268668867 for the full log.)

@jtgeibel
Copy link
Member Author

cc @Turbo87

@Turbo87
Copy link
Member

Turbo87 commented Dec 21, 2019

part of the issue was caused by ember-cli/ember-fetch#391. by now we are on [email protected], but ember-fetch is still showing the deprecation because I haven't resolved the deprecation yet. I'll have a look at that tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants