restore crate prefixes to browser-tab titles #2074
Conversation
There is a bunch of code that sets the page title dynamically, but it is all being overridden by a title tag in the main app/index.html template (the DOM is only allowed to have a single title tag in it, so subsequent title tags are ignored by all browsers). There is probably a better way to do this (using fastboot to fill in the correct title on the backend would be ideal) but this patch should be enough to restore the dynamic titles for browsers with javascript enabled.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the help! I also think it's worth it to get this in and see about fastboot afterwards. |
|
📌 Commit 3f14e8d has been approved by |
restore crate prefixes to browser-tab titles I'm not sure when it got broken, but all of the crates.io brower tabs I have open currently say `crates.io: Rust Package Registry` when they previously said things like `mio - crates.io: Rust Package Registry` or `Search Results for 'mio' - crates.io: Rust Package Registry`. This patch fixes this. There is a bunch of code that sets the page title dynamically, but it is all being overridden by a title tag in the main app/index.html template (the DOM is only allowed to have a single title tag in it, so subsequent title tags are ignored by all browsers). There is probably a better way to do this (using fastboot to fill in the correct title on the backend would be ideal) but this patch should be enough to restore the dynamic titles for browsers with javascript enabled.
|
☀️ Test successful - checks-travis |
|
This PR fixes #1930! Thank you! |
I'm not sure when it got broken, but all of the crates.io brower tabs I have open currently say
crates.io: Rust Package Registrywhen they previously said things likemio - crates.io: Rust Package RegistryorSearch Results for 'mio' - crates.io: Rust Package Registry. This patch fixes this.There is a bunch of code that sets the page title dynamically,
but it is all being overridden by a title tag in the main
app/index.html template (the DOM is only allowed to have
a single title tag in it, so subsequent title tags are
ignored by all browsers).
There is probably a better way to do this (using fastboot
to fill in the correct title on the backend would be ideal)
but this patch should be enough to restore the dynamic
titles for browsers with javascript enabled.