Skip to content

Font rendering got weird recently #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benesch opened this issue Aug 7, 2020 · 5 comments
Closed

Font rendering got weird recently #945

benesch opened this issue Aug 7, 2020 · 5 comments
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug P-medium Medium priority

Comments

@benesch
Copy link

benesch commented Aug 7, 2020

docs.rs suddenly started rendering monospace fonts quite differently.

Here's the before:

image

And here's the after:

image

Was this intentional? The only obviously glitch is the fi ligature (which is weird for a monospace font; wonder why that's happening), but as a matter of personal preference I also preferred the smaller and lighter weight fonts in the before screenshot.

@jyn514
Copy link
Member

jyn514 commented Aug 7, 2020

https://docs.rs/protobuf/2.16.2/protobuf/descriptor/struct.FileDescriptorSet.html

This is probably fallout from #930, it's not an intentional change. According to devtools this is using font-face: monospace,monospace so your default monospace font is mostly to blame, but it's still a bug on our end - we should be using rustdoc fonts.

@jyn514 jyn514 added A-frontend Area: Web frontend C-bug Category: This is a bug P-medium Medium priority labels Aug 7, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 7, 2020

I expect this is the same root cause as #935

@jyn514
Copy link
Member

jyn514 commented Aug 7, 2020

Actually I think this is #937, the pure-css files are being loaded where they weren't before. Let me try reverting those locally and see if it helps.

@jyn514
Copy link
Member

jyn514 commented Aug 7, 2020

Fixed by #946

@jyn514 jyn514 closed this as completed Aug 7, 2020
@benesch
Copy link
Author

benesch commented Aug 8, 2020

Ah yep, that fixed it right up. Thanks very much for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants