Fix warnings

Author: antoyo

.github/workflows/main.yml

@@ -33,12 +33,22 @@ jobs:
 
     - name: Build libgccjit
       run: |
+        echo "../../../gcc/gcc/jit/libgccjit.cc:3090:35: warning: unused variable ‘stmt’ [-Wunused-variable]" > build.log
+        if grep -E 'gcc/jit/.*:.*warning:' build.log; then
+            echo "Warnings detected in libgccjit"
+            exit 1
+        fi
+
         cd ..
         ls
         mkdir build install
         cd build
         ../gcc/configure --enable-host-shared --enable-languages=c,jit,lto --disable-bootstrap --disable-multilib --prefix=/usr
-        make -j4
+        bash -o pipefail -c 'make -j4 2>&1 | tee build.log'
+        if grep -E 'gcc/jit/.*:.*warning:' build.log; then
+            echo "Warnings detected in libgccjit"
+            exit 1
+        fi
         make install DESTDIR=$(pwd)/../install
 
     - name: Build Debian package

gcc/jit/jit-recording.cc

@@ -7643,7 +7643,7 @@ recording::statement::write_to_dump (dump &d)
    for recording::memento_of_set_personality_function.  */
 
 void
-recording::memento_of_set_personality_function::replay_into (replayer *r)
+recording::memento_of_set_personality_function::replay_into (replayer *)
 {
   m_function->playback_function ()->set_personality_function (m_personality_function->playback_function ());
 }

gcc/jit/jit-recording.h

@@ -658,7 +658,7 @@ class type : public memento
 
   virtual bool is_same_type_as (type *other)
   {
-    if ((is_int () && other->is_int () || is_float() && other->is_float())
+    if (((is_int () && other->is_int ()) || (is_float() && other->is_float()))
 		 && get_size () == other->get_size ()
 		 && is_signed () == other->is_signed ())
     {
@@ -2290,7 +2290,7 @@ class array_access : public lvalue
 
   void replay_into (replayer *r) final override;
 
-  void set_name (const char *new_name) final override {
+  void set_name (const char *) final override {
     m_ctxt->add_error (NULL, "cannot change the name of type `array_access`");
   }
 
@@ -2355,7 +2355,7 @@ class vector_access : public lvalue
 
   void visit_children (rvalue_visitor *v) final override;
 
-  void set_name (const char *new_name) final override {
+  void set_name (const char *) final override {
     m_ctxt->add_error (NULL, "cannot change the name of type `vector_access`");
   }
 
@@ -2388,7 +2388,7 @@ class access_field_of_lvalue : public lvalue
 
   void visit_children (rvalue_visitor *v) final override;
 
-  void set_name (const char *new_name) final override {
+  void set_name (const char *) final override {
     m_ctxt->add_error (
       NULL, "cannot change the name of type `access_field_of_lvalue`");
   }
@@ -2451,7 +2451,7 @@ class dereference_field_rvalue : public lvalue
 
   void visit_children (rvalue_visitor *v) final override;
 
-  void set_name (const char *new_name) final override {
+  void set_name (const char *) final override {
     m_ctxt->add_error (
       NULL, "cannot change the name of type `dereference_field_rvalue`");
   }
@@ -2482,7 +2482,7 @@ class dereference_rvalue : public lvalue
 
   void visit_children (rvalue_visitor *v) final override;
 
-  void set_name (const char *new_name) final override {
+  void set_name (const char *) final override {
     m_ctxt->add_error (
       NULL, "cannot change the name of type `dereference_rvalue`");
   }

gcc/jit/libgccjit.cc

@@ -805,7 +805,6 @@ gcc_jit_context_new_array_type (gcc_jit_context *ctxt,
   JIT_LOG_FUNC (ctxt->get_logger ());
   /* LOC can be NULL.  */
   RETURN_NULL_IF_FAIL (element_type, ctxt, loc, "NULL type");
-  RETURN_NULL_IF_FAIL (num_elements >= 0, ctxt, NULL, "negative size");
   RETURN_NULL_IF_FAIL (!element_type->is_void (), ctxt, loc,
 		       "void type for elements");
 
@@ -3058,7 +3057,7 @@ gcc_jit_block_add_try_catch (gcc_jit_block *block,
   RETURN_IF_FAIL (try_block, ctxt, loc, "NULL rvalue");
   RETURN_IF_FAIL (catch_block, ctxt, loc, "NULL rvalue");
 
-  gcc::jit::recording::statement *stmt = block->add_try_catch (loc, try_block, catch_block);
+  /*gcc::jit::recording::statement *stmt =*/ block->add_try_catch (loc, try_block, catch_block);
 
   // TODO: remove this or use it.
   /* "stmt" should be good enough to be usable in error-messages,