Skip to content

status_should_ignore only works for absolute paths #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacwah opened this issue Oct 29, 2016 · 2 comments
Closed

status_should_ignore only works for absolute paths #164

jacwah opened this issue Oct 29, 2016 · 2 comments

Comments

@jacwah
Copy link

jacwah commented Oct 29, 2016

Calling Repository::status_should_ignore on a path of the form ./filename always returns true regardless of the current gitignore file. I tried canonicalizing the path instead which lead to the correct result being returned.

Is this a bug in git2-rs/libgit2? Am I missing something?

Cheers

@alexcrichton
Copy link
Member

Ah unfortunately this may be behavior relative to libgit2, it looks like we just pass the file unmodified down to the lower layer.

@alexcrichton
Copy link
Member

Closing in favor of libgit2/libgit2#3979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants