Skip to content

We could deprecate c_uchar and c_schar #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gnzlbg opened this issue Sep 7, 2019 · 3 comments
Closed

We could deprecate c_uchar and c_schar #1505

gnzlbg opened this issue Sep 7, 2019 · 3 comments
Labels
C-cleanup

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 7, 2019

We guarantee that c_uchar and c_schar are always equal to u8 and i8 and we don't aim to support any platforms where this isn't the case, ever. So we could deprecate these and just recommend users to use u8 and i8 instead.
@maxbla
Copy link
Contributor

maxbla commented Oct 17, 2020

As a small counterpoint, from a user's perspective, using c_uchar and c_schar can indicate that FFI is going on.

@kellda
Copy link
Contributor

kellda commented Feb 3, 2021

This would be consistent with the deprecation of {u,}int{8,16,32,64}_t in #1304

@tgross35
Copy link
Contributor

These are defined in core::ffi now. Since they are defined there, I don't think there is any point in removing anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gnzlbg @maxbla @tgross35 @JohnTitor @kellda