Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 15b2ad5

Browse files
tgross35beetrees
andauthored
fixup! 5c220a7
Co-authored-by: beetrees <[email protected]>
1 parent f6f5946 commit 15b2ad5

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

crates/libm-test/src/special_case.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,11 @@ fn maybe_check_nan_bits<F: Float>(actual: F, expected: F, ctx: &CheckCtx) -> Opt
134134
return None;
135135
}
136136

137-
// The musl implementations uses x87 instructions on i686 which quiets signaling NaNs
138-
if cfg!(target_arch = "x86") && ctx.basis == CheckBasis::Musl && ctx.canonical_name == "fabs" {
137+
// LLVM currently uses x87 instructions which quieten signalling NaNs to handle the i686
138+
// `extern "C"` `f32`/`f64` return ABI.
139+
// LLVM issue <https://github.com/llvm/llvm-project/issues/66803>
140+
// Rust issue <https://github.com/rust-lang/rust/issues/115567>
141+
if cfg!(target_arch = "x86") && ctx.basis == CheckBasis::Musl {
139142
return SKIP;
140143
}
141144

0 commit comments

Comments
 (0)