Skip to content

Commit a51f8a6

Browse files
authored
Merge pull request #2101 from zqianem/gh-443/menu-border
Avoid menu border flash during page navigation
2 parents a204946 + 1ef8d70 commit a51f8a6

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/theme/book.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -676,13 +676,14 @@ function playground_text(playground, hidden = true) {
676676
}, { passive: true });
677677
})();
678678
(function controllBorder() {
679-
menu.classList.remove('bordered');
680-
document.addEventListener('scroll', function () {
679+
function updateBorder() {
681680
if (menu.offsetTop === 0) {
682681
menu.classList.remove('bordered');
683682
} else {
684683
menu.classList.add('bordered');
685684
}
686-
}, { passive: true });
685+
}
686+
updateBorder();
687+
document.addEventListener('scroll', updateBorder, { passive: true });
687688
})();
688689
})();

src/theme/index.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
<div class="page">
116116
{{> header}}
117117
<div id="menu-bar-hover-placeholder"></div>
118-
<div id="menu-bar" class="menu-bar sticky bordered">
118+
<div id="menu-bar" class="menu-bar sticky">
119119
<div class="left-buttons">
120120
<button id="sidebar-toggle" class="icon-button" type="button" title="Toggle Table of Contents" aria-label="Toggle Table of Contents" aria-controls="sidebar">
121121
<i class="fa fa-bars"></i>

0 commit comments

Comments
 (0)