Skip to content

Sidebar is not possible to close on certain mobile viewports #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lolbinarycat opened this issue Apr 25, 2025 · 2 comments · May be fixed by #2679
Open

Sidebar is not possible to close on certain mobile viewports #2678

lolbinarycat opened this issue Apr 25, 2025 · 2 comments · May be fixed by #2679
Assignees
@lolbinarycat
Labels
C-bug Category: A bug, incorrect or unintended behavior

Comments

@lolbinarycat
Copy link

lolbinarycat commented Apr 25, 2025 •
edited by rustbot
Loading

Problem

with a 270x495 viewport with a DPR of 4, opening the sidebar of the rust reference looks like this:

screenshot

as you can see, the "close sidebar" button is not on screen.

Steps

  1. go to https://doc.rust-lang.org/reference/ in firefox
  2. use Ctrl+Shift+M to enter responsive design mode
  3. Device dropdown > Edit List > Add Custom Device > 270x495 viewport, DPR=4
  4. open sidebar

Possible Solution(s)

  1. move the close sidebar button to align with how rustdoc works
  2. use viewport units so this can't happen

Notes

yes this corresponds to a real device, the HTC U23 Pro.

Version

unknown
@lolbinarycat lolbinarycat added the C-bug Category: A bug, incorrect or unintended behavior label Apr 25, 2025
@lolbinarycat
Copy link
Author

@rustbot claim

@lolbinarycat lolbinarycat linked a pull request Apr 25, 2025 that will close this issue
Open
@szabgab
Copy link
Contributor

szabgab commented Apr 27, 2025

I am using a Galaxy A52, and I have a similar problem there. The sidebar when opened takes up almost all the screen and it is rather hard to close it. Mostly I just click on an item by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolbinarycat lolbinarycat

Labels
C-bug Category: A bug, incorrect or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(css): sidebar can no longer be larger than 80% of viewport width lolbinarycat/mdBook
2 participants
@szabgab @lolbinarycat