Skip to content

Rethink theme management #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
budziq opened this issue Jun 23, 2017 · 1 comment
Open

Rethink theme management #351

budziq opened this issue Jun 23, 2017 · 1 comment
Labels
A-Style Area: Style (CSS, etc.) C-enhancement Category: Enhancement or feature request M-Discussion Meta: Discussion S-Wishlist Status: Wishlist

Comments

@budziq
Copy link
Contributor

budziq commented Jun 23, 2017 •
edited
Loading

As discussed in https://github.com/azerupi/mdBook/pull/338#discussion_r123618836

Discussion points:

  • Themes should be easily configured (added, removed via configuration)
    • should the themes be opt in?
  • Themes should be easily implemented.
  • Consider switching to SASS from stylus due to nice rust bindings.
@budziq budziq mentioned this issue Jun 23, 2017
Merged
@azerupi azerupi added A-Style Area: Style (CSS, etc.) M-Discussion Meta: Discussion S-Wishlist Status: Wishlist C-enhancement Category: Enhancement or feature request labels Jun 24, 2017
@mattico mattico mentioned this issue Feb 8, 2018
Closed
@evanjs
Copy link

evanjs commented Sep 8, 2019

It would also be nice if we had a set of themes common to both rustdoc and mdBook.
I've been torn on where to post this as it deals with both projects, but this issue seems pretty relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Style Area: Style (CSS, etc.) C-enhancement Category: Enhancement or feature request M-Discussion Meta: Discussion S-Wishlist Status: Wishlist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@budziq @evanjs @azerupi