-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Include dependencies #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a pretty frequently raised issue (see #463, #46, #271, rust-lang/book#711). The current behaviour is to first try the CDNs when loading 3rd party CSS/JS (to make use of caching and all that), falling back to local versions if they're not available (original copies are here)... What exactly did you have in mind when you say all dependencies should be served locally? |
In my case I'm fine with retrieval from the cdn at build time, but I'd rather the generated pages link to local copies. This means I can then also serve the output up without relying on any external resources and without being blocked by more privacy focused browsers. |
Is this on the roadmap? |
The dependencies problem is definitely still on the roadmap. The big three things we want to improve over the coming months are plugin support, dependencies, and juggling multilingual books and translations. I think progress has stalled due to not knowing the full requirements of all stakeholders (e.g. developers, "normal" users, debian package maintainers, and slow networks) and because we don't know what the right way to go is. @mattico threw around the idea of bundling all dependencies into a single @mattico and @sorin-davidoi, what are your thoughts on having an initial PR which removes the need for CDNs altogether? Do we have any tangible evidence that we are benefiting from using a CDN? @steveklabnik, do you know if this would adversely affect The Book? |
Ok thanks for the reply! I'll hold my horses and see how this issue develops, maybe I'll pitch in later. |
I'd be on board with a PR removing CDN links entirely, even before we figure out what else we want to do. |
I looked into this a bit. |
I'm going to close as a duplicate of the aforementioned issues. I believe mathjax is the only thing loaded remotely. |
Thanks for the great tool! I'm very much enjoying it!
It would be great to have an option to include all dependencies like images, fonts and js etc. rather than linking directly to a cdn. So all the required media are included and served locally.
The text was updated successfully, but these errors were encountered: