From d6720fc671385ed9564f7b9226c7898cea20df82 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Thu, 23 Jan 2025 13:58:35 +0100 Subject: [PATCH 1/2] Update browser-ui-test version to 0.19.0 --- .github/workflows/main.yml | 2 +- tests/gui/runner.rs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c7e04f4e31..aa67503d91 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -4,7 +4,7 @@ on: merge_group: env: - BROWSER_UI_TEST_VERSION: '0.18.2' + BROWSER_UI_TEST_VERSION: '0.19.0' jobs: test: diff --git a/tests/gui/runner.rs b/tests/gui/runner.rs index 93f2a44893..ff808a72c5 100644 --- a/tests/gui/runner.rs +++ b/tests/gui/runner.rs @@ -75,7 +75,6 @@ fn main() { let mut command = Command::new("npx"); command .arg("browser-ui-test") - .arg("--no-sandbox") .args(["--variable", "DOC_PATH", book_dir.as_str()]) .args(["--test-folder", "tests/gui"]); if std::env::args().any(|arg| arg == "--disable-headless-test") { From ce63cc31f450c8a37dd6f4c4102b1aefb19a0ba4 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Thu, 23 Jan 2025 14:01:38 +0100 Subject: [PATCH 2/2] Add GUI regression test for #2529 --- tests/gui/sidebar-nojs.goml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 tests/gui/sidebar-nojs.goml diff --git a/tests/gui/sidebar-nojs.goml b/tests/gui/sidebar-nojs.goml new file mode 100644 index 0000000000..9a8622f94a --- /dev/null +++ b/tests/gui/sidebar-nojs.goml @@ -0,0 +1,16 @@ +// This GUI test checks that the sidebar takes the whole height when it's inside +// an iframe (because of JS disabled). +// Regression test for . + +// We disable the requests checks because `searchindex.json` will always fail +// locally. +fail-on-request-error: false +// We disable javascript +javascript: false +go-to: |DOC_PATH| + "index.html" +store-value: (height, 1000) +set-window-size: (1000, |height|) + +within-iframe: (".sidebar-iframe-outer", block { + assert-size: (" body", {"height": |height|}) +})