Skip to content

Use NPM packages for executing stylus #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ishitatsuyuki
Copy link

This allows:

  • Not polluting global /usr/bin
  • Managing dependencies with proper version requirements so things don't break

@ishitatsuyuki
Copy link
Author

Hmm, command execution doesn't work correctly on Windows. I'll debug later.

@ishitatsuyuki
Copy link
Author

Addressed. Can this get a review?

@frewsxcv
Copy link
Member

frewsxcv commented Jul 3, 2018

Any reason why need to use yarn instead of just using npm's lockfile?

@ishitatsuyuki
Copy link
Author

It's just a matter of preference, but in many cases, yarn lockfile has a more stable output than NPM's one. In the JS community, I've seen more and more repos opting out of NPM's lockfile.

@mattico
Copy link
Contributor

mattico commented Jul 25, 2018

I'd prefer to remove stylus altogether (#636), and plan to do that after the next release. If we do end up sticking with stylus, however, this PR looks good to me.

@ishitatsuyuki
Copy link
Author

This PR is also a groundwork for dealing with NPM packages, which you will probably end up using as long as web is concerned.

Even if we got rid of stylus, it's likely that we will be using something like PostCSS as compatibility (on top of bleeding edge) is always a thing to care about.

@Dylan-DPC-zz
Copy link

@ishitatsuyuki can you resolve the conflicts?

@ishitatsuyuki
Copy link
Author

@Dylan-DPC I think someone have already ditched stylus so this is obsolete.

@Dylan-DPC-zz
Copy link

Ah didn't realise that. Thanks for pointing that. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants