Merge pull request #7 from oli-obk/compiletest

use compiletest_rs

Author: solson

Cargo.lock

@@ -12,3 +12,6 @@ name = "miri"
 
 [dependencies]
 byteorder = "0.4.2"
+
+[dev-dependencies]
+compiletest_rs = "0.1.1"

Cargo.toml

@@ -6,14 +6,13 @@ extern crate rustc_driver;
 
 use miri::interpreter;
 use rustc::session::Session;
-use rustc_driver::{driver, CompilerCalls, Compilation};
+use rustc_driver::{driver, CompilerCalls};
 
 struct MiriCompilerCalls;
 
 impl<'a> CompilerCalls<'a> for MiriCompilerCalls {
     fn build_controller(&mut self, _: &Session) -> driver::CompileController<'a> {
         let mut control = driver::CompileController::basic();
-        control.after_analysis.stop = Compilation::Stop;
 
         control.after_analysis.callback = Box::new(|state| {
             state.session.abort_if_errors();

src/bin/miri.rs

@@ -1,4 +1,3 @@
-#![crate_type = "lib"]
 #![feature(custom_attribute)]
 #![allow(dead_code, unused_attributes)]
 
@@ -9,33 +8,33 @@ fn overwriting_part_of_relocation_makes_the_rest_undefined() -> i32 {
         let ptr: *mut _ = &mut p;
         *(ptr as *mut u32) = 123;
     }
-    *p
+    *p //~ ERROR: attempted to read undefined bytes
 }
 
 #[miri_run]
 fn pointers_to_different_allocations_are_unorderable() -> bool {
     let x: *const u8 = &1;
     let y: *const u8 = &2;
-    x < y
+    x < y //~ ERROR: attempted to do math or a comparison on pointers into different allocations
 }
 
 #[miri_run]
 fn invalid_bool() -> u8 {
     let b = unsafe { std::mem::transmute::<u8, bool>(2) };
-    if b { 1 } else { 2 }
+    if b { 1 } else { 2 } //~ ERROR: invalid boolean value read
 }
 
 #[miri_run]
 fn undefined_byte_read() -> u8 {
     let v: Vec<u8> = Vec::with_capacity(10);
     let undef = unsafe { *v.get_unchecked(5) };
-    undef + 1
+    undef + 1 //~ ERROR: attempted to read undefined bytes
 }
 
 #[miri_run]
 fn out_of_bounds_read() -> u8 {
     let v: Vec<u8> = vec![1, 2];
-    unsafe { *v.get_unchecked(5) }
+    unsafe { *v.get_unchecked(5) } //~ ERROR: pointer offset outside bounds of allocation
 }
 
 #[miri_run]
@@ -44,5 +43,7 @@ fn dangling_pointer_deref() -> i32 {
         let b = Box::new(42);
         &*b as *const i32
     };
-    unsafe { *p }
+    unsafe { *p } //~ ERROR: dangling pointer was dereferenced
 }
+
+fn main() {}

tests/run-pass/errors.rs renamed to tests/compile-fail/errors.rs

@@ -0,0 +1,23 @@
+extern crate compiletest_rs as compiletest;
+
+use std::path::PathBuf;
+
+fn run_mode(mode: &'static str) {
+    let mut config = compiletest::default_config();
+    config.rustc_path = "target/debug/miri".into();
+    let path = std::env::var("RUST_SYSROOT").expect("env variable `RUST_SYSROOT` not set");
+    config.target_rustcflags = Some(format!("--sysroot {}", path));
+    config.host_rustcflags = Some(format!("--sysroot {}", path));
+    let cfg_mode = mode.parse().ok().expect("Invalid mode");
+
+    config.mode = cfg_mode;
+    config.src_base = PathBuf::from(format!("tests/{}", mode));
+
+    compiletest::run_tests(&config);
+}
+
+#[test]
+fn compile_test() {
+    run_mode("compile-fail");
+    run_mode("run-pass");
+}

tests/compile-test.rs

@@ -1,4 +1,3 @@
-#![crate_type = "lib"]
 #![feature(custom_attribute)]
 #![allow(dead_code, unused_attributes)]
 
@@ -33,3 +32,5 @@ fn index() -> i32 {
 fn array_repeat() -> [u8; 8] {
     [42; 8]
 }
+
+fn main() {}

tests/compiletest.rs

@@ -1,4 +1,3 @@
-#![crate_type = "lib"]
 #![feature(custom_attribute)]
 #![allow(dead_code, unused_attributes)]
 
@@ -27,3 +26,5 @@ fn match_bool() -> i16 {
         _ => 0,
     }
 }
+
+fn main() {}

tests/run-pass/arrays.rs

@@ -1,4 +1,3 @@
-#![crate_type = "lib"]
 #![feature(custom_attribute)]
 #![allow(dead_code, unused_attributes)]
 
@@ -20,3 +19,5 @@ fn unsafe_match() -> bool {
         _ => false,
     }
 }
+
+fn main() {}

tests/run-pass/bools.rs

@@ -1,4 +1,3 @@
-#![crate_type = "lib"]
 #![feature(custom_attribute)]
 #![allow(dead_code, unused_attributes)]
 
@@ -39,3 +38,5 @@ fn cross_crate_fn_call() -> i64 {
 fn test_size_of() -> usize {
     ::std::mem::size_of::<Option<i32>>()
 }
+
+fn main() {}