Skip to content

Make it compile for wasm #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vmx opened this issue Nov 30, 2017 · 7 comments
Closed

Make it compile for wasm #422

vmx opened this issue Nov 30, 2017 · 7 comments

Comments

@vmx
Copy link

vmx commented Nov 30, 2017

There's been a fruitful discussion at #421 on how to get regex to compile on the wasm32 target.

I decided to open a new issue to outline the next steps.

  • Make a new release of memchr. Current HEAD already contains the changes that are needed.
  • Make a new release of libc. Current HEAD has already changes that make memchr compile smoothly on wasm32.

Let's see if that's enough or further things are needed. I'll check ones the above ones are done.

@BurntSushi
Copy link
Member

memchr 2.0.1 is out. I can't do anything about libc. :-)

@vmx
Copy link
Author

vmx commented Nov 30, 2017

@BurntSushi: I've one more for you. aho-corasick needs a new release. The current one is still using memchr 1.x.

@BurntSushi
Copy link
Member

@vmx Done. I also put out a new release of regex, which also hadn't been seen a release since memchr got bumped.

@vmx
Copy link
Author

vmx commented Nov 30, 2017

I've open an issue on libc (rust-lang/libc#861) to do a new release. After that it should be possible to compile regex for wasm32.

@BurntSushi
Copy link
Member

@vmx Looks like this is done! I fully expect to be using this regex crate in the browser by tonight. :P

@vmx
Copy link
Author

vmx commented Dec 1, 2017

My LALRPOP grammer (which uses regex) works in the browser, hence I consider this done. Thanks again everyone that was involved.

@vmx vmx closed this as completed Dec 1, 2017
@BurntSushi
Copy link
Member

@vmx w00t! If there's a way to share a demo that would be really awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants