Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Commit 968129d

Browse files
committed
Auto merge of #1244 - Xanewok:translate-tests, r=alexheretic
Translate cmd tests to use async LSP client This translates our cmd-based tests to use the LSP client introduced in #1223. Some anecdotal benchmarks (Xubuntu 18.04, Ryzen 2600) before and after translating: ``` $ time cargo test cmd_ real 0m3,498s user 0m8,379s sys 0m2,710s $ time cargo test cmd_ --release real 0m3,059s user 0m5,585s sys 0m2,512s $ time cargo test client_ real 0m3,465s user 0m7,197s sys 0m1,926s $ time cargo test client_ --release real 0m3,053s user 0m4,977s sys 0m1,825s ``` It seems that synchronization overhead caused by running multiple RLS and rustc instances in-process still outweighs spawning separate processes per test 🎉 That means we don't lose performance (and actually benefit) from switching over. I plan on translating the remaining tests in tests_old as a separate PR. r? @alexheretic
2 parents 41bc0bf + 663e437 commit 968129d

File tree

5 files changed

+1104
-1560
lines changed

5 files changed

+1104
-1560
lines changed

Cargo.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ rustc-workspace-hack = "1.0.0"
6161
[dev-dependencies]
6262
difference = "2"
6363
tempfile = "3"
64-
lsp-codec = "0.1"
64+
lsp-codec = "0.1.1"
6565
tokio = "0.1"
6666
futures = "0.1"
6767
tokio-process = "0.2"

0 commit comments

Comments
 (0)