Skip to content

Commit 4ad0a1b

Browse files
bors[bot]Azorlogh
andauthored
Merge #10053
10053: Remove old workaround in vscode extension r=lnicola a=Azorlogh See #3167. Co-authored-by: = <[email protected]>
2 parents 8f683e9 + e3dd43c commit 4ad0a1b

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

editors/code/src/net.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -200,19 +200,4 @@ async function downloadFile(
200200
const srcStream = gunzip ? res.body.pipe(zlib.createGunzip()) : res.body;
201201

202202
await pipeline(srcStream, destFileStream);
203-
204-
// Don't apply the workaround in fixed versions of nodejs, since the process
205-
// freezes on them, the process waits for no-longer emitted `close` event.
206-
// The fix was applied in commit 7eed9d6bcc in v13.11.0
207-
// See the nodejs changelog:
208-
// https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md
209-
const [, major, minor] = /v(\d+)\.(\d+)\.(\d+)/.exec(process.version)!;
210-
if (+major > 13 || (+major === 13 && +minor >= 11)) return;
211-
212-
await new Promise<void>(resolve => {
213-
destFileStream.on("close", resolve);
214-
destFileStream.destroy();
215-
// This workaround is awaiting to be removed when vscode moves to newer nodejs version:
216-
// https://github.com/rust-analyzer/rust-analyzer/issues/3167
217-
});
218203
}

0 commit comments

Comments
 (0)