Skip to content

Commit af9a9ab

Browse files
bors[bot]Veetaha
and
Veetaha
authored
Merge #3092
3092: vscode: fix binary is not functional on windows r=matklad a=Veetaha This is my first approach to fix this error, need to double-check this on windows still... Fixes #3087 Fixes #3090 Co-authored-by: Veetaha <[email protected]>
2 parents 6ac871b + 78ee964 commit af9a9ab

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

editors/code/src/installation/download_file.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ export async function downloadFile(
2727
readBytes += chunk.length;
2828
onProgress(readBytes, totalBytes);
2929
})
30-
.on("end", resolve)
3130
.on("error", reject)
32-
.pipe(fs.createWriteStream(destFilePath))
31+
.pipe(fs.createWriteStream(destFilePath).on("close", resolve))
3332
);
3433
}

0 commit comments

Comments
 (0)