#![allow(non_upper_case_globals)] not working correctly in proc macros

[sunmy2019]

rust-analyzer version: rust-analyzer version: 0.3.1599-standalone

rustc version: rustc 1.68.2 (9eb3afe9e 2023-03-27)

relevant settings: num_enum == 0.6.1

It is erroneously diagnosing it as nonupper case globals. cargo build and cargo check works without any warnings.

I tried the built-in macro expand. That line does exist.

If I copied that expansion to the source code directly, everything works fine.

It looks like the allow implementation is wrong.

[sunmy2019]

I suspect changes in #15320 exposed this bug.

[lowr]

I'd say this is a duplicate of #6541, but we may want to suppress the warning that originates in macro expansions.

[HKalbasi]

I tried to ignore diagnostics from proc macros in #14990 since rustc ignores them (rustc doesn't ignore all of them, but I didn't find out what rustc exactly does). @sunmy2019 Can you try to see if it happens in that commit as well?

[sunmy2019]

@sunmy2019 Can you try to see if it happens in that commit as well?

I don't get it. v0.3.1599 contains that commit 45272ef already.

[HKalbasi]

I want to see if it worked then originally and regressed later, or it didn't work even then.

[sunmy2019]

I can confirm that rust-analyzer 0.3.1591-standalone is working as expected.

[huntc]

Howdy. Is there a known work-around to this issue? Thanks.

[sunmy2019]

Howdy. Is there a known work-around to this issue? Thanks.

I added a global #![allow(...)] for it.

[tgross35]

@Veykril it seems like your fix may have only corrected derive macros, I am still hitting this error with functionlike macros. Should this issue remain open, or does that seem incorrect?

Using v0.3.1673