Skip to content

vec! macro is considered unsafe on latest nightly toolchain #18842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Jan 6, 2025 · 5 comments · Fixed by #18843
Closed

vec! macro is considered unsafe on latest nightly toolchain #18842

Veykril opened this issue Jan 6, 2025 · 5 comments · Fixed by #18843
Assignees
@Veykril
Labels
Broken Window Bugs / technical debt to be addressed immediately

Comments

@Veykril
Copy link
Member

Veykril commented Jan 6, 2025

somehow this surfaced for me in 2025!

Image

Originally posted by @bionicles in #10047
@Veykril Veykril added the Broken Window Bugs / technical debt to be addressed immediately label Jan 6, 2025
@Veykril
Copy link
Member Author

Veykril commented Jan 6, 2025

Looks like the vec macro now expands to a new intrinsic box_new which is unsafe

@Veykril
Copy link
Member Author

Veykril commented Jan 6, 2025 •
edited
Loading

rust-lang/rust@e3010e8 makes this annoying, we now need to check the toolchain version to know the safety of an intrinsic (for some migration period). Reeason being that that commit flipped the default unsafety of intrinsics!

@Veykril Veykril self-assigned this Jan 6, 2025
@Veykril
Copy link
Member Author

Veykril commented Jan 6, 2025

Actually we are in luck given the legacy ones use extern blocks with a specific ABI

@Veykril Veykril mentioned this issue Jan 6, 2025
Merged
@Veykril Veykril mentioned this issue Jan 6, 2025
Closed
@lnicola lnicola marked this as a duplicate of #18871 Jan 7, 2025
@lnicola lnicola mentioned this issue Feb 14, 2025
Closed
@bsodmike
Copy link

Started seeing this last week or so. Switched to beta and it's gone.

@ChayimFriedman2 ChayimFriedman2 mentioned this issue Apr 10, 2025
Closed
@aurexav
Copy link

aurexav commented Apr 10, 2025 •
edited
Loading

Started seeing this last week or so. Switched to beta and it's gone.

I'm on pre-release channel. Switched to release channel and it's gone.

There might be some bugs in the package update logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Veykril Veykril

Labels
Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Handle newstyle rustc_intrinsic safety correctly Veykril/rust-analyzer
3 participants
@bsodmike @Veykril @aurexav