Skip to content

Commit 2776076

Browse files
committed
Auto merge of #7977 - Jarcho:multi_needless_borrow, r=xFrednet
Improve `needless_borrow` lint fixes: #5327 fixes: #1726 fixes: #1212 This is merging `needless_borrow` into the `dereference` pass in preparation for `explicit_auto_deref`. `explicit_auto_deref` needs to implement most of what `needless_borrow` implements in order to work. There is a minor regression here where `let x: &str = &x.deref()` will trigger `needless_borrow` without triggering `explicit_deref_methods`. Removing the redundant borrow will cause `explicit_deref_methods` to trigger. This will be fixed when `explicit_auto_deref` is implemented. changelog: Lint `needless_borrow` when a borrow is auto-derefed more than once changelog: Lint `needless_borrow` in the trailing expression of a block for a match arm
2 parents 8dd1bce + 8ded385 commit 2776076

11 files changed

+425
-306
lines changed

clippy_lints/src/bytecount.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,10 @@ impl<'tcx> LateLintPass<'tcx> for ByteCount {
7474
if (p == sym::iter || p == sym!(iter_mut)) && args.len() == 1 {
7575
&args[0]
7676
} else {
77-
&filter_recv
77+
filter_recv
7878
}
7979
} else {
80-
&filter_recv
80+
filter_recv
8181
};
8282
let mut applicability = Applicability::MaybeIncorrect;
8383
span_lint_and_sugg(

0 commit comments

Comments
 (0)