Simplify logic

maekawatoshiki · maekawatoshiki · commit 5f8d8f165606 · 2024-03-14T12:48:34.000+09:00
diff --git a/clippy_lints/src/methods/map_clone.rs b/clippy_lints/src/methods/map_clone.rs
@@ -122,9 +122,8 @@ fn handle_path(
             && let args = args.as_slice()
             && let Some(ty) = args.iter().find_map(|generic_arg| generic_arg.as_type())
             && let ty::Ref(_, ty, Mutability::Not) = ty.kind()
-            && let ty::Adt(_, args) = cx.typeck_results().expr_ty(e).kind()
-            && let args = args.as_slice()
-            && args.iter().find_map(|generic_arg| generic_arg.as_type()) == Some(*ty)
+            && let ty::FnDef(_, lst) = cx.typeck_results().expr_ty(arg).kind()
+            && lst.iter().all(|l| l.as_type() == Some(*ty))
         {
             lint_path(cx, e.span, recv.span, is_copy(cx, ty.peel_refs()));
         }

Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,8 @@ fn handle_path(`
`122`	`122`	`&& let args = args.as_slice()`
`123`	`123`	`&& let Some(ty) = args.iter().find_map(\|generic_arg\| generic_arg.as_type())`
`124`	`124`	`&& let ty::Ref(_, ty, Mutability::Not) = ty.kind()`
`125`		`- && let ty::Adt(_, args) = cx.typeck_results().expr_ty(e).kind()`
`126`		`- && let args = args.as_slice()`
`127`		`- && args.iter().find_map(\|generic_arg\| generic_arg.as_type()) == Some(*ty)`
	`125`	`+ && let ty::FnDef(_, lst) = cx.typeck_results().expr_ty(arg).kind()`
	`126`	`+ && lst.iter().all(\|l\| l.as_type() == Some(*ty))`
`128`	`127`	`{`
`129`	`128`	`lint_path(cx, e.span, recv.span, is_copy(cx, ty.peel_refs()));`
`130`	`129`	`}`