duration_suboptimal_units: print the complete method name in the suggestion

ada4a · ada4a · commit ac3c58ddc6bf · 2026-05-12T17:37:33.000+02:00
diff --git a/clippy_lints/src/duration_suboptimal_units.rs b/clippy_lints/src/duration_suboptimal_units.rs
@@ -99,7 +99,7 @@ impl LateLintPass<'_> for DurationSuboptimalUnits {
                         (arg.span, promoted_value.to_string()),
                     ];
                     diag.multipart_suggestion(
-                        format!("try using {promoted_constructor}"),
+                        format!("try using `Duration::{promoted_constructor}`"),
                         suggestions,
                         Applicability::MachineApplicable,
                     );
diff --git a/tests/ui/duration_suboptimal_units.stderr b/tests/ui/duration_suboptimal_units.stderr
@@ -6,7 +6,7 @@ LL |     let dur = Duration::from_secs(60);
    |
    = note: `-D clippy::duration-suboptimal-units` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::duration_suboptimal_units)]`
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -     let dur = Duration::from_secs(60);
 LL +     let dur = Duration::from_mins(1);
@@ -18,7 +18,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_secs(180);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -     let dur = Duration::from_secs(180);
 LL +     let dur = Duration::from_mins(3);
@@ -30,7 +30,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_secs(10 * 60);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -     let dur = Duration::from_secs(10 * 60);
 LL +     let dur = Duration::from_mins(10);
@@ -42,7 +42,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_mins(24 * 60);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_hours
+help: try using `Duration::from_hours`
    |
 LL -     let dur = Duration::from_mins(24 * 60);
 LL +     let dur = Duration::from_hours(24);
@@ -54,7 +54,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_millis(5_000);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_secs
+help: try using `Duration::from_secs`
    |
 LL -     let dur = Duration::from_millis(5_000);
 LL +     let dur = Duration::from_secs(5);
@@ -66,7 +66,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_nanos(13 * 60 * 60 * 1_000 * 1_000 * 1_000);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_hours
+help: try using `Duration::from_hours`
    |
 LL -     let dur = Duration::from_nanos(13 * 60 * 60 * 1_000 * 1_000 * 1_000);
 LL +     let dur = Duration::from_hours(13);
@@ -78,7 +78,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |         let dur = Duration::from_millis(5_000);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_secs
+help: try using `Duration::from_secs`
    |
 LL -         let dur = Duration::from_millis(5_000);
 LL +         let dur = Duration::from_secs(5);
@@ -90,7 +90,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |         let dur = Duration::from_secs(180);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -         let dur = Duration::from_secs(180);
 LL +         let dur = Duration::from_mins(3);
@@ -102,7 +102,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |         let dur = Duration::from_mins(24 * 60);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_hours
+help: try using `Duration::from_hours`
    |
 LL -         let dur = Duration::from_mins(24 * 60);
 LL +         let dur = Duration::from_hours(24);
@@ -114,7 +114,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     std::time::Duration::from_secs(60);
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -     std::time::Duration::from_secs(60);
 LL +     std::time::Duration::from_mins(1);
@@ -126,7 +126,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     assert_eq!(Duration::from_secs(3_600), Duration::from_mins(6));
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_hours
+help: try using `Duration::from_hours`
    |
 LL -     assert_eq!(Duration::from_secs(3_600), Duration::from_mins(6));
 LL +     assert_eq!(Duration::from_hours(1), Duration::from_mins(6));
@@ -142,7 +142,7 @@ LL |     let dur = mac!(duration);
    |               -------------- in this macro invocation
    |
    = note: this error originates in the macro `mac` (in Nightly builds, run with -Z macro-backtrace for more info)
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -         Duration::from_secs(300)
 LL +         Duration::from_mins(5)
@@ -154,7 +154,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     _ = Duration::from_secs(67_768_040_922_076_800);
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_hours
+help: try using `Duration::from_hours`
    |
 LL -     _ = Duration::from_secs(67_768_040_922_076_800);
 LL +     _ = Duration::from_hours(18824455811688);
diff --git a/tests/ui/duration_suboptimal_units_days_weeks.stderr b/tests/ui/duration_suboptimal_units_days_weeks.stderr
@@ -6,7 +6,7 @@ LL |     let dur = Duration::from_secs(60);
    |
    = note: `-D clippy::duration-suboptimal-units` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::duration_suboptimal_units)]`
-help: try using from_mins
+help: try using `Duration::from_mins`
    |
 LL -     let dur = Duration::from_secs(60);
 LL +     let dur = Duration::from_mins(1);
@@ -18,7 +18,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_hours(24);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_days
+help: try using `Duration::from_days`
    |
 LL -     let dur = Duration::from_hours(24);
 LL +     let dur = Duration::from_days(1);
@@ -30,7 +30,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
 LL |     let dur = Duration::from_nanos(13 * 7 * 24 * 60 * 60 * 1_000 * 1_000 * 1_000);
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-help: try using from_weeks
+help: try using `Duration::from_weeks`
    |
 LL -     let dur = Duration::from_nanos(13 * 7 * 24 * 60 * 60 * 1_000 * 1_000 * 1_000);
 LL +     let dur = Duration::from_weeks(13);

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ LL \| let dur = Duration::from_secs(60);`
`6`	`6`	`\|`
`7`	`7`	= note: `-D clippy::duration-suboptimal-units` implied by `-D warnings`
`8`	`8`	= help: to override `-D warnings` add `#[allow(clippy::duration_suboptimal_units)]`
`9`		`-help: try using from_mins`
	`9`	+help: try using `Duration::from_mins`
`10`	`10`	`\|`
`11`	`11`	`LL - let dur = Duration::from_secs(60);`
`12`	`12`	`LL + let dur = Duration::from_mins(1);`
@@ -18,7 +18,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`18`	`18`	`LL \| let dur = Duration::from_secs(180);`
`19`	`19`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^`
`20`	`20`	`\|`
`21`		`-help: try using from_mins`
	`21`	+help: try using `Duration::from_mins`
`22`	`22`	`\|`
`23`	`23`	`LL - let dur = Duration::from_secs(180);`
`24`	`24`	`LL + let dur = Duration::from_mins(3);`
@@ -30,7 +30,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`30`	`30`	`LL \| let dur = Duration::from_secs(10 * 60);`
`31`	`31`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`32`	`32`	`\|`
`33`		`-help: try using from_mins`
	`33`	+help: try using `Duration::from_mins`
`34`	`34`	`\|`
`35`	`35`	`LL - let dur = Duration::from_secs(10 * 60);`
`36`	`36`	`LL + let dur = Duration::from_mins(10);`
@@ -42,7 +42,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`42`	`42`	`LL \| let dur = Duration::from_mins(24 * 60);`
`43`	`43`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`44`	`44`	`\|`
`45`		`-help: try using from_hours`
	`45`	+help: try using `Duration::from_hours`
`46`	`46`	`\|`
`47`	`47`	`LL - let dur = Duration::from_mins(24 * 60);`
`48`	`48`	`LL + let dur = Duration::from_hours(24);`
@@ -54,7 +54,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`54`	`54`	`LL \| let dur = Duration::from_millis(5_000);`
`55`	`55`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`56`	`56`	`\|`
`57`		`-help: try using from_secs`
	`57`	+help: try using `Duration::from_secs`
`58`	`58`	`\|`
`59`	`59`	`LL - let dur = Duration::from_millis(5_000);`
`60`	`60`	`LL + let dur = Duration::from_secs(5);`
@@ -66,7 +66,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`66`	`66`	`LL \| let dur = Duration::from_nanos(13 * 60 * 60 * 1_000 * 1_000 * 1_000);`
`67`	`67`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`68`	`68`	`\|`
`69`		`-help: try using from_hours`
	`69`	+help: try using `Duration::from_hours`
`70`	`70`	`\|`
`71`	`71`	`LL - let dur = Duration::from_nanos(13 * 60 * 60 * 1_000 * 1_000 * 1_000);`
`72`	`72`	`LL + let dur = Duration::from_hours(13);`
@@ -78,7 +78,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`78`	`78`	`LL \| let dur = Duration::from_millis(5_000);`
`79`	`79`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`80`	`80`	`\|`
`81`		`-help: try using from_secs`
	`81`	+help: try using `Duration::from_secs`
`82`	`82`	`\|`
`83`	`83`	`LL - let dur = Duration::from_millis(5_000);`
`84`	`84`	`LL + let dur = Duration::from_secs(5);`
@@ -90,7 +90,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`90`	`90`	`LL \| let dur = Duration::from_secs(180);`
`91`	`91`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^`
`92`	`92`	`\|`
`93`		`-help: try using from_mins`
	`93`	+help: try using `Duration::from_mins`
`94`	`94`	`\|`
`95`	`95`	`LL - let dur = Duration::from_secs(180);`
`96`	`96`	`LL + let dur = Duration::from_mins(3);`
@@ -102,7 +102,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`102`	`102`	`LL \| let dur = Duration::from_mins(24 * 60);`
`103`	`103`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`104`	`104`	`\|`
`105`		`-help: try using from_hours`
	`105`	+help: try using `Duration::from_hours`
`106`	`106`	`\|`
`107`	`107`	`LL - let dur = Duration::from_mins(24 * 60);`
`108`	`108`	`LL + let dur = Duration::from_hours(24);`
@@ -114,7 +114,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`114`	`114`	`LL \| std::time::Duration::from_secs(60);`
`115`	`115`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`116`	`116`	`\|`
`117`		`-help: try using from_mins`
	`117`	+help: try using `Duration::from_mins`
`118`	`118`	`\|`
`119`	`119`	`LL - std::time::Duration::from_secs(60);`
`120`	`120`	`LL + std::time::Duration::from_mins(1);`
@@ -126,7 +126,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`126`	`126`	`LL \| assert_eq!(Duration::from_secs(3_600), Duration::from_mins(6));`
`127`	`127`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^`
`128`	`128`	`\|`
`129`		`-help: try using from_hours`
	`129`	+help: try using `Duration::from_hours`
`130`	`130`	`\|`
`131`	`131`	`LL - assert_eq!(Duration::from_secs(3_600), Duration::from_mins(6));`
`132`	`132`	`LL + assert_eq!(Duration::from_hours(1), Duration::from_mins(6));`
`@@ -142,7 +142,7 @@ LL \| let dur = mac!(duration);`
`142`	`142`	`\| -------------- in this macro invocation`
`143`	`143`	`\|`
`144`	`144`	= note: this error originates in the macro `mac` (in Nightly builds, run with -Z macro-backtrace for more info)
`145`		`-help: try using from_mins`
	`145`	+help: try using `Duration::from_mins`
`146`	`146`	`\|`
`147`	`147`	`LL - Duration::from_secs(300)`
`148`	`148`	`LL + Duration::from_mins(5)`
@@ -154,7 +154,7 @@ error: constructing a `Duration` using a smaller unit when a larger unit would b
`154`	`154`	`LL \| _ = Duration::from_secs(67_768_040_922_076_800);`
`155`	`155`	`\| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^`
`156`	`156`	`\|`
`157`		`-help: try using from_hours`
	`157`	+help: try using `Duration::from_hours`
`158`	`158`	`\|`
`159`	`159`	`LL - _ = Duration::from_secs(67_768_040_922_076_800);`
`160`	`160`	`LL + _ = Duration::from_hours(18824455811688);`