Skip to content

Switch to rustc's in_external_macro function once it's available #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phansch opened this issue Jul 17, 2018 · 0 comments
Closed

Switch to rustc's in_external_macro function once it's available #2929

phansch opened this issue Jul 17, 2018 · 0 comments
Labels
good-first-issue These issues are a good way to get started with Clippy S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work T-macros Type: Issues with macros and macro expansion

Comments

@phansch
Copy link
Member

phansch commented Jul 17, 2018

Once rust-lang/rust#52467 is merged and on nightly, we can remove our own in_external_macro function and use the one from rustc instead.

After that's done, it makes sense to review the issues under the T-macros label.
@phansch phansch added good-first-issue These issues are a good way to get started with Clippy T-macros Type: Issues with macros and macro expansion S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Jul 17, 2018
@dwijnand dwijnand mentioned this issue Jul 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue These issues are a good way to get started with Clippy S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work T-macros Type: Issues with macros and macro expansion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phansch