Enable test empty_loop_no_std on windows #9254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dswij
approved these changes
Jul 28, 2022
Member
dswij
left a comment
dswij
left a comment
There was a problem hiding this comment.
Thanks!
I couldn't find the reason we're ignoring this though, curious about this.
Contributor
|
I'm guessing it had something to do with the Compiler flag? 🤔 |
Member
Author
|
Not sure why, but seems it was here #5086 Probably, @Areredify remember why so? |
Member
|
Well if the test is passing, I guess it's fine then. Thanks again for this! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Aug 2, 2022
…ws, r=dswij Enable test empty_loop_no_std on windows Verified that it actully works on windows changelog: none
Contributor
|
💔 Test failed - checks-action_test |
Member
|
@bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that it actully works on windows
changelog: none