Skip to content

Prevent output pane text from being copied as HTML #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Prevent output pane text from being copied as HTML #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ui/frontend/Output/SimplePane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,19 @@ interface HighlightErrorsProps {
label: string;
}

const onOutputPrismCopy: React.ClipboardEventHandler = event => {
// Blank out HTML copy data.
// Though linkified output is handy in the Playground, it does more harm
// than good when copied elsewhere, and terminal output is usable on its own.
const selection = document.getSelection();
if (selection) {
event.clipboardData.setData('text/plain', selection.toString());
event.preventDefault();
}
};

const HighlightErrors: React.FC<HighlightErrorsProps> = ({ label, children }) => (
<div data-test-id="output-stderr">
<div data-test-id="output-stderr" onCopy={onOutputPrismCopy}>
<Header label={label} />
<OutputPrism languageCode="language-rust_errors">
{children}
Expand Down