Add validation to inline_fluent messages

Author: JonathanBrouwer

compiler/rustc_const_eval/src/errors.rs

@@ -393,16 +393,17 @@ impl Subdiagnostic for FrameNote {
         }
         let msg = diag.eagerly_translate(inline_fluent!(
             r#"{$times ->
-    [0] {const_eval_frame_note_inner}
-    *[other] [... {$times} additional calls {const_eval_frame_note_inner} ...]
-}
-
-const_eval_frame_note_inner = inside {$where_ ->
-    [closure] closure
-    [instance] `{$instance}`
-    *[other] {""}
-}
-"#
+                [0] inside {$where_ ->
+                    [closure] closure
+                    [instance] `{$instance}`
+                    *[other] {""}
+                }
+                *[other] [... {$times} additional calls inside {$where_ ->
+                    [closure] closure
+                    [instance] `{$instance}`
+                    *[other] {""}
+                } ...]
+            }"#
         ));
         diag.remove_arg("times");
         diag.remove_arg("where_");

compiler/rustc_macros/src/diagnostics/inline_fluent.rs

@@ -1,10 +1,11 @@
-use quote::quote;
 use syn::{LitStr, parse_macro_input};
+use crate::diagnostics::message::Message;
 
 pub(crate) fn inline_fluent(input: proc_macro::TokenStream) -> proc_macro::TokenStream {
     let inline = parse_macro_input!(input as LitStr);
-    quote! {
-        rustc_errors::DiagMessage::Inline(std::borrow::Cow::Borrowed(#inline))
-    }
-    .into()
+    let message = Message {
+        message_span: inline.span(),
+        value: inline.value(),
+    };
+    message.diag_message(None).into()
 }