Skip to content

Commit 0a06e34

Browse files
committed
syntax: remove use of pub use globs
For quasiquoters, two (priv) `use` globs are injected.
1 parent aa15195 commit 0a06e34

17 files changed

+32
-8
lines changed

src/libsyntax/ext/build.rs

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ use ext::quote::rt::*;
1919
use fold::Folder;
2020
use owned_slice::OwnedSlice;
2121
use parse::token::special_idents;
22+
use parse::token::InternedString;
2223
use parse::token;
2324

2425
pub struct Field {

src/libsyntax/ext/deriving/bounds.rs

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use ast::{MetaItem, MetaWord, Item};
1212
use codemap::Span;
1313
use ext::base::ExtCtxt;
1414
use ext::deriving::generic::*;
15+
use ext::deriving::generic::ty::*;
1516

1617
pub fn expand_deriving_bound(cx: &mut ExtCtxt,
1718
span: Span,

src/libsyntax/ext/deriving/clone.rs

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use codemap::Span;
1313
use ext::base::ExtCtxt;
1414
use ext::build::AstBuilder;
1515
use ext::deriving::generic::*;
16+
use ext::deriving::generic::ty::*;
1617
use parse::token::InternedString;
1718

1819
pub fn expand_deriving_clone(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/cmp/eq.rs

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use codemap::Span;
1313
use ext::base::ExtCtxt;
1414
use ext::build::AstBuilder;
1515
use ext::deriving::generic::*;
16+
use ext::deriving::generic::ty::*;
1617
use parse::token::InternedString;
1718

1819
pub fn expand_deriving_eq(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/cmp/ord.rs

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use codemap::Span;
1414
use ext::base::ExtCtxt;
1515
use ext::build::AstBuilder;
1616
use ext::deriving::generic::*;
17+
use ext::deriving::generic::ty::*;
1718
use parse::token::InternedString;
1819

1920
pub fn expand_deriving_ord(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/cmp/totaleq.rs

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use codemap::Span;
1313
use ext::base::ExtCtxt;
1414
use ext::build::AstBuilder;
1515
use ext::deriving::generic::*;
16+
use ext::deriving::generic::ty::*;
1617
use parse::token::InternedString;
1718

1819
pub fn expand_deriving_totaleq(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/cmp/totalord.rs

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use codemap::Span;
1414
use ext::base::ExtCtxt;
1515
use ext::build::AstBuilder;
1616
use ext::deriving::generic::*;
17+
use ext::deriving::generic::ty::*;
1718
use parse::token::InternedString;
1819

1920
use std::cmp::{Ordering, Equal, Less, Greater};

src/libsyntax/ext/deriving/decodable.rs

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ use codemap::Span;
1919
use ext::base::ExtCtxt;
2020
use ext::build::AstBuilder;
2121
use ext::deriving::generic::*;
22+
use ext::deriving::generic::ty::*;
2223
use parse::token::InternedString;
2324
use parse::token;
2425

src/libsyntax/ext/deriving/default.rs

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use codemap::Span;
1313
use ext::base::ExtCtxt;
1414
use ext::build::AstBuilder;
1515
use ext::deriving::generic::*;
16+
use ext::deriving::generic::ty::*;
1617
use parse::token::InternedString;
1718

1819
pub fn expand_deriving_default(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/encodable.rs

+1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ use codemap::Span;
8888
use ext::base::ExtCtxt;
8989
use ext::build::AstBuilder;
9090
use ext::deriving::generic::*;
91+
use ext::deriving::generic::ty::*;
9192
use parse::token;
9293

9394
pub fn expand_deriving_encodable(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/generic/mod.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,9 @@ use codemap::Span;
191191
use owned_slice::OwnedSlice;
192192
use parse::token::InternedString;
193193

194-
pub use self::ty::*;
195-
mod ty;
194+
use self::ty::*;
195+
196+
pub mod ty;
196197

197198
pub struct TraitDef<'a> {
198199
/// The span for the current #[deriving(Foo)] header.

src/libsyntax/ext/deriving/hash.rs

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use codemap::Span;
1414
use ext::base::ExtCtxt;
1515
use ext::build::AstBuilder;
1616
use ext::deriving::generic::*;
17+
use ext::deriving::generic::ty::*;
1718
use parse::token::InternedString;
1819

1920
pub fn expand_deriving_hash(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/primitive.rs

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use codemap::Span;
1414
use ext::base::ExtCtxt;
1515
use ext::build::AstBuilder;
1616
use ext::deriving::generic::*;
17+
use ext::deriving::generic::ty::*;
1718
use parse::token::InternedString;
1819

1920
pub fn expand_deriving_from_primitive(cx: &mut ExtCtxt,

src/libsyntax/ext/deriving/rand.rs

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use codemap::Span;
1414
use ext::base::ExtCtxt;
1515
use ext::build::{AstBuilder};
1616
use ext::deriving::generic::*;
17+
use ext::deriving::generic::ty::*;
1718

1819
pub fn expand_deriving_rand(cx: &mut ExtCtxt,
1920
span: Span,

src/libsyntax/ext/deriving/show.rs

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ use ext::format;
1515
use ext::base::ExtCtxt;
1616
use ext::build::AstBuilder;
1717
use ext::deriving::generic::*;
18+
use ext::deriving::generic::ty::*;
1819
use parse::token;
1920

2021
use collections::HashMap;

src/libsyntax/ext/deriving/zero.rs

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use codemap::Span;
1313
use ext::base::ExtCtxt;
1414
use ext::build::AstBuilder;
1515
use ext::deriving::generic::*;
16+
use ext::deriving::generic::ty::*;
1617
use parse::token::InternedString;
1718

1819
pub fn expand_deriving_zero(cx: &mut ExtCtxt,

src/libsyntax/ext/quote.rs

+14-6
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,13 @@ pub mod rt {
3636
use parse;
3737
use print::pprust;
3838

39+
// NOTE remove this after snapshot
40+
// (stage0 quasiquoter needs this)
41+
#[cfg(stage0)]
3942
pub use ast::*;
43+
#[cfg(stage0)]
4044
pub use parse::token::*;
45+
4146
pub use parse::new_parser_from_tts;
4247
pub use codemap::{BytePos, Span, dummy_spanned};
4348

@@ -72,7 +77,7 @@ pub mod rt {
7277

7378
impl ToSource for ast::Ident {
7479
fn to_source(&self) -> String {
75-
get_ident(*self).get().to_string()
80+
token::get_ident(*self).get().to_string()
7681
}
7782
}
7883

@@ -685,11 +690,14 @@ fn expand_wrapper(cx: &ExtCtxt,
685690
sp: Span,
686691
cx_expr: @ast::Expr,
687692
expr: @ast::Expr) -> @ast::Expr {
688-
let uses = vec![ cx.view_use_glob(sp, ast::Inherited,
689-
ids_ext(vec!["syntax".to_string(),
690-
"ext".to_string(),
691-
"quote".to_string(),
692-
"rt".to_string()])) ];
693+
let uses = [
694+
&["syntax", "ext", "quote", "rt"],
695+
&["syntax", "ast"],
696+
&["syntax", "parse", "token"],
697+
].iter().map(|path| {
698+
let path = path.iter().map(|s| s.to_string()).collect();
699+
cx.view_use_glob(sp, ast::Inherited, ids_ext(path))
700+
}).collect();
693701

694702
let stmt_let_ext_cx = cx.stmt_let(sp, false, id_ext("ext_cx"), cx_expr);
695703

0 commit comments

Comments
 (0)