Skip to content

Commit 1e25878

Browse files
authored
Rollup merge of #69397 - tmiasko:llvm-version-suffix, r=nagisa
bootstrap: Remove commit hash from LLVM version suffix to avoid rebuilds The custom LLVM version suffix was introduced to avoid unintentional library names conflicts. By default it included the LLVM submodule commit hash. Changing the version suffix requires the complete LLVM rebuild, and since then every change to the submodules required it as well. Remove the commit hash from version suffix to avoid complete rebuilds, while leaving the `rust` string, the release number and release channel to disambiguate the library name. Context: version suffix was introduced by #59173 as solution to #59034. Resolves #68715.
2 parents d905134 + 598b187 commit 1e25878

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/bootstrap/native.rs

+2-6
Original file line numberDiff line numberDiff line change
@@ -241,12 +241,8 @@ impl Step for Llvm {
241241
cfg.define("LLVM_VERSION_SUFFIX", suffix);
242242
}
243243
} else {
244-
let mut default_suffix =
245-
format!("-rust-{}-{}", channel::CFG_RELEASE_NUM, builder.config.channel,);
246-
if let Some(sha) = llvm_info.sha_short() {
247-
default_suffix.push_str("-");
248-
default_suffix.push_str(sha);
249-
}
244+
let default_suffix =
245+
format!("-rust-{}-{}", channel::CFG_RELEASE_NUM, builder.config.channel);
250246
cfg.define("LLVM_VERSION_SUFFIX", default_suffix);
251247
}
252248

0 commit comments

Comments
 (0)