Skip to content

Commit 2417731

Browse files
committed
Update MinGW comments in ci.yml
1 parent d495ef5 commit 2417731

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/ci/github-actions/ci.yml

+7-5
Original file line numberDiff line numberDiff line change
@@ -490,15 +490,17 @@ jobs:
490490

491491
# 32/64-bit MinGW builds.
492492
#
493-
# We are using MinGW with posix threads since LLVM does not compile with
494-
# the win32 threads version due to missing support for C++'s std::thread.
493+
# We are using MinGW with POSIX threads since LLVM requires
494+
# C++'s std::thread which is disabled in libstdc++ with win32 threads.
495+
# FIXME: Libc++ doesn't have this limitation so we can avoid
496+
# winpthreads if we switch to it.
495497
#
496-
# Instead of relying on the MinGW version installed on appveryor we download
497-
# and install one ourselves so we won't be surprised by changes to appveyor's
498+
# Instead of relying on the MinGW version installed on CI we download
499+
# and install one ourselves so we won't be surprised by changes to CI's
498500
# build image.
499501
#
500502
# Finally, note that the downloads below are all in the `rust-lang-ci` S3
501-
# bucket, but they cleraly didn't originate there! The downloads originally
503+
# bucket, but they clearly didn't originate there! The downloads originally
502504
# came from the mingw-w64 SourceForge download site. Unfortunately
503505
# SourceForge is notoriously flaky, so we mirror it on our own infrastructure.
504506

0 commit comments

Comments
 (0)