add test coverage for rustc "if-unchanged" paths

Signed-off-by: onur-ozkan <[email protected]>

Author: onur-ozkan

src/bootstrap/src/core/config/config.rs

@@ -37,7 +37,7 @@ use crate::utils::helpers::{self, exe, output, t};
 ///
 /// WARNING: Be cautious when adding paths to this list. If a path that influences the compiler build
 /// is added here, it will cause bootstrap to skip necessary rebuilds, which may lead to risky results.
-const RUSTC_IF_UNCHANGED_ALLOWED_PATHS: &[&str] = &[
+pub(crate) const RUSTC_IF_UNCHANGED_ALLOWED_PATHS: &[&str] = &[
     ":!.github",
     ":!.clang-format",
     ":!.editorconfig",
@@ -72,7 +72,7 @@ const RUSTC_IF_UNCHANGED_ALLOWED_PATHS: &[&str] = &[
 ];
 
 /// Holds subpaths from [`RUSTC_IF_UNCHANGED_ALLOWED_PATHS`] that should not be allowed.
-const RUSTC_IF_UNCHANGED_DENIED_SUBPATHS: &[&str] = &[
+pub(crate) const RUSTC_IF_UNCHANGED_DENIED_SUBPATHS: &[&str] = &[
     "src/stage0",
     "src/version",
     "src/ci/channel",

src/bootstrap/src/core/config/tests.rs

@@ -8,7 +8,9 @@ use clap::CommandFactory;
 use serde::Deserialize;
 
 use super::flags::Flags;
-use super::{ChangeIdWrapper, Config};
+use super::{
+    ChangeIdWrapper, Config, RUSTC_IF_UNCHANGED_ALLOWED_PATHS, RUSTC_IF_UNCHANGED_DENIED_SUBPATHS,
+};
 use crate::core::build_steps::clippy::get_clippy_rules_in_order;
 use crate::core::build_steps::llvm;
 use crate::core::config::{LldMode, Target, TargetSelection, TomlConfig};
@@ -352,3 +354,30 @@ fn parse_rust_std_features_empty() {
 fn parse_rust_std_features_invalid() {
     parse("rust.std-features = \"backtrace\"");
 }
+
+#[test]
+fn check_rustc_if_unchaged_paths() {
+    let config = parse("");
+    let normalised_allowed_paths: Vec<_> = RUSTC_IF_UNCHANGED_ALLOWED_PATHS
+        .iter()
+        .map(|t| {
+            t.strip_prefix(":!").expect(&format!("{t} doesn't have ':!' prefix, but it should."))
+        })
+        .collect();
+
+    let check_existence = |paths| {
+        for p in paths {
+            assert!(config.src.join(p).exists(), "{p} doesn't exist.");
+        }
+    };
+
+    check_existence(normalised_allowed_paths.as_slice());
+    check_existence(RUSTC_IF_UNCHANGED_DENIED_SUBPATHS);
+
+    for p in RUSTC_IF_UNCHANGED_DENIED_SUBPATHS {
+        assert!(
+            normalised_allowed_paths.iter().any(|t| p.starts_with(t)),
+            "{p} is not a subpath of an allowed path, there is no need to keep it in the denied list."
+        );
+    }
+}