Skip to content

Commit 2782e8f

Browse files
committed
Auto merge of #38867 - alexcrichton:ignore-test-on-windows, r=brson
std: Ignore close_read_wakes_up on Windows It looks like in practice at least this test will not pass on Windows. Empirically it is prone to blocking forever, presumably because a call to `shutdown` doesn't actually wake up other threads on Windows. We don't document this as a guarantee for `shutdown`, nor do we internally rely on it. This test originated in a time long since passed when it was leveraged for canceling I/O, but nowadays there's nothing fancy happening in the standard library so it's not really a productive test anyway, hence just ignoring it on Windows. Closes #31657
2 parents 1ca100d + 7eb43f1 commit 2782e8f

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/libstd/net/tcp.rs

+1
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,7 @@ mod tests {
11531153
}
11541154

11551155
#[test]
1156+
#[cfg(unix)] // test doesn't work on Windows, see #31657
11561157
fn close_read_wakes_up() {
11571158
each_ip(&mut |addr| {
11581159
let a = t!(TcpListener::bind(&addr));

0 commit comments

Comments
 (0)