Point turbofish inference errors at the uninferred generic arg

Author: arferreira

compiler/rustc_trait_selection/src/error_reporting/infer/need_type_info.rs

@@ -1272,7 +1272,21 @@ impl<'a, 'tcx> Visitor<'tcx> for FindInferSourceVisitor<'a, 'tcx> {
                 let generic_args =
                     &generics.own_args_no_defaults(tcx, args)[generics.own_counts().lifetimes..];
                 let span = match expr.kind {
-                    ExprKind::MethodCall(path, ..) => path.ident.span,
+                    ExprKind::MethodCall(segment, ..) => {
+                        if have_turbofish
+                            && let Some(hir_args) = segment.args
+                            && let Some(idx) = argument_index.checked_sub(
+                                generics.has_own_self() as usize
+                                    + generics.own_counts().lifetimes,
+                            )
+                            && let Some(arg) =
+                                hir_args.args.iter().filter(|a| a.is_ty_or_const()).nth(idx)
+                        {
+                            arg.span()
+                        } else {
+                            segment.ident.span
+                        }
+                    }
                     _ => expr.span,
                 };
 

tests/ui/inference/useless-turbofish-suggestion.rs

@@ -4,8 +4,8 @@
 // rewriting them — the suggestion just rewrites user syntax into
 // fully-qualified form without resolving anything.
 //
-// The span still points at the method name rather than the unresolved `_`;
-// fixing that is left as future work.
+// When a turbofish is present, the diagnostic points at the specific
+// uninferred generic argument rather than the method name.
 
 struct S;
 
@@ -15,11 +15,16 @@ impl S {
     }
 }
 
-fn with_turbofish() {
+fn turbofish_second_arg() {
     S.f::<u32, _>(42);
     //~^ ERROR type annotations needed
 }
 
+fn turbofish_first_arg() {
+    S.f::<_, _>(42);
+    //~^ ERROR type annotations needed
+}
+
 fn without_turbofish() {
     S.f(42);
     //~^ ERROR type annotations needed

tests/ui/inference/useless-turbofish-suggestion.stderr

@@ -1,11 +1,17 @@
 error[E0282]: type annotations needed
-  --> $DIR/useless-turbofish-suggestion.rs:19:7
+  --> $DIR/useless-turbofish-suggestion.rs:19:16
    |
 LL |     S.f::<u32, _>(42);
-   |       ^ cannot infer type of the type parameter `B` declared on the method `f`
+   |                ^ cannot infer type of the type parameter `B` declared on the method `f`
+
+error[E0282]: type annotations needed
+  --> $DIR/useless-turbofish-suggestion.rs:24:14
+   |
+LL |     S.f::<_, _>(42);
+   |              ^ cannot infer type of the type parameter `B` declared on the method `f`
 
 error[E0282]: type annotations needed
-  --> $DIR/useless-turbofish-suggestion.rs:24:7
+  --> $DIR/useless-turbofish-suggestion.rs:29:7
    |
 LL |     S.f(42);
    |       ^ cannot infer type of the type parameter `B` declared on the method `f`
@@ -15,6 +21,6 @@ help: consider specifying the generic arguments
 LL |     S.f::<i32, B>(42);
    |        ++++++++++
 
-error: aborting due to 2 previous errors
+error: aborting due to 3 previous errors
 
 For more information about this error, try `rustc --explain E0282`.

tests/ui/issues/issue-23041.stderr

@@ -1,8 +1,8 @@
 error[E0282]: type annotations needed
-  --> $DIR/issue-23041.rs:6:7
+  --> $DIR/issue-23041.rs:6:22
    |
 LL |     b.downcast_ref::<fn(_)->_>();
-   |       ^^^^^^^^^^^^ cannot infer type of the type parameter `T` declared on the method `downcast_ref`
+   |                      ^^^^^^^^ cannot infer type of the type parameter `T` declared on the method `downcast_ref`
 
 error: aborting due to 1 previous error
 

tests/ui/span/issue-42234-unknown-receiver-type.stderr

@@ -12,10 +12,10 @@ LL |     let x: Option<_> = None::<T>;
    |                            +++++
 
 error[E0282]: type annotations needed
-  --> $DIR/issue-42234-unknown-receiver-type.rs:12:10
+  --> $DIR/issue-42234-unknown-receiver-type.rs:12:16
    |
 LL |         .sum::<_>()
-   |          ^^^ cannot infer type of the type parameter `S` declared on the method `sum`
+   |                ^ cannot infer type of the type parameter `S` declared on the method `sum`
 
 error: aborting due to 2 previous errors