You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add missing inline annotations to Cell
Were seeing some odd performance problems when using incremental compilation where `Rc` pointers were actually slower than `Arc` pointers (the problem goes away when using non-incremental compilation). I haven't been able to build rustc locally to verify that this fixes it but these missing inline annotations seem to be the only thing that could affect performance (to this extent).
```
test vector_push_back ... bench: 11,668,015 ns/iter (+/- 772,861)
test vector_push_back_mut ... bench: 1,423,771 ns/iter (+/- 22,011)
test vector_push_back_mut_rc ... bench: 1,181,765 ns/iter (+/- 123,724)
test vector_push_back_rc ... bench: 17,141,746 ns/iter (+/- 203,048)
```
(Source and non incremental benchmarks orium/rpds#7 (comment))
0 commit comments