Remove lint annotations in specific crates that are already enforced by rustbuild

Remove some random unnecessary lint `allow`s

Author: petrochenkov

src/bootstrap/bin/main.rs

@@ -5,7 +5,8 @@
 //! parent directory, and otherwise documentation can be found throughout the `build`
 //! directory in each respective module.
 
-#![deny(warnings)]
+// NO-RUSTC-WRAPPER
+#![deny(warnings, rust_2018_idioms)]
 
 use std::env;
 

src/bootstrap/bin/rustc.rs

@@ -15,7 +15,8 @@
 //! switching compilers for the bootstrap and for build scripts will probably
 //! never get replaced.
 
-#![deny(warnings)]
+// NO-RUSTC-WRAPPER
+#![deny(warnings, rust_2018_idioms)]
 
 use std::env;
 use std::ffi::OsString;

src/bootstrap/bin/rustdoc.rs

@@ -2,7 +2,8 @@
 //!
 //! See comments in `src/bootstrap/rustc.rs` for more information.
 
-#![deny(warnings)]
+// NO-RUSTC-WRAPPER
+#![deny(warnings, rust_2018_idioms)]
 
 use std::env;
 use std::process::Command;

src/bootstrap/lib.rs

@@ -103,8 +103,9 @@
 //! More documentation can be found in each respective module below, and you can
 //! also check out the `src/bootstrap/README.md` file for more information.
 
-#![deny(rust_2018_idioms)]
-#![deny(warnings)]
+// NO-RUSTC-WRAPPER
+#![deny(warnings, rust_2018_idioms)]
+
 #![feature(core_intrinsics)]
 #![feature(drain_filter)]
 

src/build_helper/lib.rs

@@ -1,4 +1,5 @@
-#![deny(rust_2018_idioms)]
+// NO-RUSTC-WRAPPER
+#![deny(warnings, rust_2018_idioms)]
 
 use std::fs::File;
 use std::path::{Path, PathBuf};

src/liballoc/lib.rs

@@ -62,8 +62,6 @@
 #![warn(missing_docs)]
 #![warn(missing_debug_implementations)]
 #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
-
-#![deny(rust_2018_idioms)]
 #![allow(explicit_outlives_requirements)]
 
 #![cfg_attr(not(test), feature(generator_trait))]

src/liballoc/tests/lib.rs

@@ -8,7 +8,6 @@
 #![feature(trusted_len)]
 #![feature(try_reserve)]
 #![feature(unboxed_closures)]
-#![deny(rust_2018_idioms)]
 
 use std::hash::{Hash, Hasher};
 use std::collections::hash_map::DefaultHasher;

src/libarena/lib.rs

@@ -11,7 +11,6 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/",
        test(no_crate_inject, attr(deny(warnings))))]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #![feature(core_intrinsics)]

src/libcore/lib.rs

@@ -62,8 +62,6 @@
 #![warn(missing_docs)]
 #![warn(missing_debug_implementations)]
 #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
-
-#![deny(rust_2018_idioms)]
 #![allow(explicit_outlives_requirements)]
 
 #![feature(allow_internal_unstable)]

src/libcore/tests/lib.rs

@@ -32,7 +32,6 @@
 #![feature(const_fn)]
 #![feature(iter_partition_in_place)]
 #![feature(iter_is_partitioned)]
-#![warn(rust_2018_idioms)]
 
 extern crate test;
 

src/libfmt_macros/lib.rs

@@ -8,7 +8,6 @@
        html_playground_url = "https://play.rust-lang.org/",
        test(attr(deny(warnings))))]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #![feature(nll)]

src/libgraphviz/lib.rs

@@ -274,8 +274,6 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/",
        test(attr(allow(unused_variables), deny(warnings))))]
 
-#![deny(rust_2018_idioms)]
-
 #![feature(nll)]
 
 use LabelText::*;

src/libpanic_abort/lib.rs

@@ -10,7 +10,6 @@
 #![panic_runtime]
 
 #![allow(unused_features)]
-#![deny(rust_2018_idioms)]
 
 #![feature(core_intrinsics)]
 #![feature(libc)]

src/libpanic_unwind/lib.rs

@@ -17,8 +17,6 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/",
        issue_tracker_base_url = "https://github.com/rust-lang/rust/issues/")]
 
-#![deny(rust_2018_idioms)]
-
 #![feature(core_intrinsics)]
 #![feature(lang_items)]
 #![feature(libc)]

src/libproc_macro/lib.rs

@@ -17,8 +17,6 @@
        test(no_crate_inject, attr(deny(warnings))),
        test(attr(allow(dead_code, deprecated, unused_variables, unused_mut))))]
 
-#![deny(rust_2018_idioms)]
-
 #![feature(nll)]
 #![feature(staged_api)]
 #![feature(const_fn)]

src/libprofiler_builtins/lib.rs

@@ -7,4 +7,3 @@
 #![allow(unused_features)]
 #![feature(nll)]
 #![feature(staged_api)]
-#![deny(rust_2018_idioms)]

src/librustc/error_codes.rs

@@ -1,5 +1,3 @@
-#![allow(non_snake_case)]
-
 // Error messages for EXXXX errors.
 // Each message should start and end with a new line, and be wrapped to 80 characters.
 // In vim you can `:set tw=80` and use `gq` to wrap paragraphs. Use `:set tw=0` to disable.

src/librustc/lib.rs

@@ -28,7 +28,6 @@
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #![feature(arbitrary_self_types)]
@@ -81,8 +80,7 @@ extern crate libc;
 
 // Use the test crate here so we depend on getopts through it. This allow tools to link to both
 // librustc_driver and libtest.
-#[allow(unused_extern_crates)]
-extern crate test;
+extern crate test as _;
 
 #[macro_use]
 mod macros;

src/librustc/session/config.rs

@@ -1628,7 +1628,7 @@ impl RustcOptGroup {
 // *unstable* options, i.e., options that are only enabled when the
 // user also passes the `-Z unstable-options` debugging flag.
 mod opt {
-    // The `fn opt_u` etc below are written so that we can use them
+    // The `fn flag*` etc below are written so that we can use them
     // in the future; do not warn about them not being used right now.
     #![allow(dead_code)]
 

src/librustc/ty/query/job.rs

@@ -1,4 +1,4 @@
-#![allow(warnings)]
+#![allow(unused_imports)] // `cfg(parallel_compiler)`
 
 use std::mem;
 use std::process;
@@ -138,6 +138,7 @@ impl<'tcx> QueryJob<'tcx> {
         self.latch.set();
     }
 
+    #[cfg(parallel_compiler)]
     fn as_ptr(&self) -> *const QueryJob<'tcx> {
         self as *const _
     }

src/librustc_apfloat/lib.rs

@@ -32,7 +32,6 @@
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
 #![forbid(unsafe_code)]
-#![deny(rust_2018_idioms)]
 
 #![feature(nll)]
 

src/librustc_asan/lib.rs

@@ -6,5 +6,3 @@
 #![unstable(feature = "sanitizer_runtime_lib",
             reason = "internal implementation detail of sanitizers",
             issue = "0")]
-
-#![deny(rust_2018_idioms)]

src/librustc_ast_borrowck/lib.rs

@@ -1,7 +1,6 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
 
 #![allow(non_camel_case_types)]
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #![feature(in_band_lifetimes)]

src/librustc_codegen_llvm/error_codes.rs

@@ -1,5 +1,3 @@
-#![allow(non_snake_case)]
-
 register_long_diagnostics! {
 
 E0511: r##"

src/librustc_codegen_llvm/intrinsic.rs

@@ -1,5 +1,3 @@
-#![allow(non_upper_case_globals)]
-
 use crate::attributes;
 use crate::llvm;
 use crate::llvm_util;

src/librustc_codegen_llvm/lib.rs

@@ -12,7 +12,6 @@
 #![feature(crate_visibility_modifier)]
 #![feature(extern_types)]
 #![feature(in_band_lifetimes)]
-#![allow(unused_attributes)]
 #![feature(libc)]
 #![feature(nll)]
 #![feature(rustc_diagnostic_macros)]
@@ -22,7 +21,6 @@
 #![feature(static_nobundle)]
 #![feature(trusted_len)]
 #![feature(mem_take)]
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 use back::write::{create_target_machine, create_informational_target_machine};

src/librustc_codegen_llvm/llvm/ffi.rs

@@ -1,3 +1,6 @@
+#![allow(non_camel_case_types)]
+#![allow(non_upper_case_globals)]
+
 use super::debuginfo::{
     DIBuilder, DIDescriptor, DIFile, DILexicalBlock, DISubprogram, DIType,
     DIBasicType, DIDerivedType, DICompositeType, DIScope, DIVariable,

src/librustc_codegen_llvm/llvm/mod.rs

@@ -1,7 +1,4 @@
-#![allow(non_upper_case_globals)]
-#![allow(non_camel_case_types)]
 #![allow(non_snake_case)]
-#![deny(bare_trait_objects)]
 
 pub use self::IntPredicate::*;
 pub use self::RealPredicate::*;

src/librustc_codegen_llvm/type_.rs

@@ -1,5 +1,3 @@
-#![allow(non_upper_case_globals)]
-
 pub use crate::llvm::Type;
 
 use crate::llvm;

src/librustc_codegen_ssa/base.rs

@@ -781,12 +781,6 @@ impl CrateInfo {
     }
 }
 
-fn is_codegened_item(tcx: TyCtxt<'_>, id: DefId) -> bool {
-    let (all_mono_items, _) =
-        tcx.collect_and_partition_mono_items(LOCAL_CRATE);
-    all_mono_items.contains(&id)
-}
-
 pub fn provide_both(providers: &mut Providers<'_>) {
     providers.backend_optimization_level = |tcx, cratenum| {
         let for_speed = match tcx.sess.opts.optimize {

src/librustc_codegen_ssa/error_codes.rs

@@ -1,5 +1,3 @@
-#![allow(non_snake_case)]
-
 register_long_diagnostics! {
 
 E0668: r##"

src/librustc_codegen_ssa/lib.rs

@@ -11,9 +11,6 @@
 #![feature(nll)]
 #![feature(trusted_len)]
 #![feature(mem_take)]
-#![allow(unused_attributes)]
-#![allow(dead_code)]
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #![recursion_limit="256"]

src/librustc_codegen_utils/codegen_backend.rs

@@ -5,8 +5,6 @@
 //! This API is completely unstable and subject to change.
 
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
-#![deny(warnings)]
-#![feature(box_syntax)]
 
 use std::any::Any;
 use std::sync::mpsc;

src/librustc_codegen_utils/lib.rs

@@ -10,13 +10,11 @@
 #![feature(core_intrinsics)]
 #![feature(never_type)]
 #![feature(nll)]
-#![allow(unused_attributes)]
 #![feature(rustc_diagnostic_macros)]
 #![feature(in_band_lifetimes)]
 
 #![recursion_limit="256"]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #[macro_use]

src/librustc_data_structures/lib.rs

@@ -26,7 +26,6 @@
 #![cfg_attr(unix, feature(libc))]
 #![cfg_attr(test, feature(test))]
 
-#![deny(rust_2018_idioms)]
 #![cfg_attr(not(bootstrap), allow(rustc::default_hash_types))]
 
 #[macro_use]

src/librustc_driver/lib.rs

@@ -16,7 +16,6 @@
 
 #![recursion_limit="256"]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 pub extern crate getopts;

src/librustc_errors/lib.rs

@@ -5,11 +5,9 @@
 #![doc(html_root_url = "https://doc.rust-lang.org/nightly/")]
 
 #![feature(crate_visibility_modifier)]
-#![allow(unused_attributes)]
 #![cfg_attr(unix, feature(libc))]
 #![feature(nll)]
 #![feature(optin_builtin_traits)]
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 pub use emitter::ColorConfig;

src/librustc_fs_util/lib.rs

@@ -1,5 +1,3 @@
-#![deny(rust_2018_idioms)]
-
 use std::path::{Path, PathBuf};
 use std::ffi::CString;
 use std::fs;

src/librustc_incremental/lib.rs

@@ -8,7 +8,6 @@
 
 #![recursion_limit="256"]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
 #[macro_use] extern crate rustc;

src/librustc_interface/interface.rs

@@ -12,7 +12,6 @@ use rustc_data_structures::OnDrop;
 use rustc_data_structures::sync::Lrc;
 use rustc_data_structures::fx::{FxHashSet, FxHashMap};
 use rustc_metadata::cstore::CStore;
-use std::io::Write;
 use std::path::PathBuf;
 use std::result;
 use std::sync::{Arc, Mutex};

src/librustc_interface/lib.rs

@@ -6,11 +6,8 @@
 #![feature(generators)]
 #![cfg_attr(unix, feature(libc))]
 
-#![deny(rust_2018_idioms)]
 #![deny(unused_lifetimes)]
 
-#![allow(unused_imports)]
-
 #![recursion_limit="256"]
 
 #[cfg(unix)]