Modify stability attributes so CI can build, only impl Clone if T is Copy

James Munns · James Munns · commit 4676b10670ca · 2018-11-01T13:03:11.000+01:00
diff --git a/src/libcore/cell.rs b/src/libcore/cell.rs
@@ -1512,16 +1512,14 @@ impl<T: ?Sized> UnsafeCell<T> {
     }
 }
 
-// TODO: correct stable attribute
-#[stable(feature = "rust1", since = "1.0.0")]
-impl<T: Clone> Clone for UnsafeCell<T> {
+#[stable(feature = "unsafe_cell_copy_clone_conservative", since = "1.31.0")]
+impl<T: Clone + Copy> Clone for UnsafeCell<T> {
     fn clone(&self) -> UnsafeCell<T> {
         UnsafeCell::new(self.value.clone())
     }
 }
 
-// TODO: correct stable attribute
-#[stable(feature = "rust1", since = "1.0.0")]
+#[stable(feature = "unsafe_cell_copy_clone_conservative", since = "1.31.0")]
 impl<T: Copy> Copy for UnsafeCell<T> {}
 
 #[stable(feature = "unsafe_cell_default", since = "1.10.0")]

Original file line number	Diff line number	Diff line change
`@@ -1512,16 +1512,14 @@ impl<T: ?Sized> UnsafeCell<T> {`
`1512`	`1512`	`}`
`1513`	`1513`	`}`
`1514`	`1514`
`1515`		`-// TODO: correct stable attribute`
`1516`		`-#[stable(feature = "rust1", since = "1.0.0")]`
`1517`		`-impl<T: Clone> Clone for UnsafeCell<T> {`
	`1515`	`+#[stable(feature = "unsafe_cell_copy_clone_conservative", since = "1.31.0")]`
	`1516`	`+impl<T: Clone + Copy> Clone for UnsafeCell<T> {`
`1518`	`1517`	`fn clone(&self) -> UnsafeCell<T> {`
`1519`	`1518`	`UnsafeCell::new(self.value.clone())`
`1520`	`1519`	`}`
`1521`	`1520`	`}`
`1522`	`1521`
`1523`		`-// TODO: correct stable attribute`
`1524`		`-#[stable(feature = "rust1", since = "1.0.0")]`
	`1522`	`+#[stable(feature = "unsafe_cell_copy_clone_conservative", since = "1.31.0")]`
`1525`	`1523`	`impl<T: Copy> Copy for UnsafeCell<T> {}`
`1526`	`1524`
`1527`	`1525`	`#[stable(feature = "unsafe_cell_default", since = "1.10.0")]`