Skip to content

Commit 59d5c74

Browse files
committed
Update use_suggestion_placement.rs test, removing the FIXME that this PR fixes.
(There is another issue, in that the fixed output is not ideally indented, but that is a pre-existing issue and should not block this PR.)
1 parent fda9a56 commit 59d5c74

File tree

3 files changed

+5
-13
lines changed

3 files changed

+5
-13
lines changed

src/test/ui/resolve/use_suggestion_placement.fixed

+1-5
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,9 @@ mod m {
1414
}
1515

1616
mod foo {
17-
// FIXME: UsePlacementFinder is broken because active attributes are
18-
// removed, and thus the `derive` attribute here is not in the AST.
19-
// An inert attribute should work, though.
20-
// #[derive(Debug)]
2117
use std::path::Path;
2218

23-
#[allow(warnings)]
19+
#[derive(Debug)]
2420
pub struct Foo;
2521

2622
// test whether the use suggestion isn't

src/test/ui/resolve/use_suggestion_placement.rs

+1-5
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ mod m {
1010
}
1111

1212
mod foo {
13-
// FIXME: UsePlacementFinder is broken because active attributes are
14-
// removed, and thus the `derive` attribute here is not in the AST.
15-
// An inert attribute should work, though.
16-
// #[derive(Debug)]
17-
#[allow(warnings)]
13+
#[derive(Debug)]
1814
pub struct Foo;
1915

2016
// test whether the use suggestion isn't

src/test/ui/resolve/use_suggestion_placement.stderr

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
error[E0412]: cannot find type `Path` in this scope
2-
--> $DIR/use_suggestion_placement.rs:22:16
2+
--> $DIR/use_suggestion_placement.rs:18:16
33
|
44
LL | type Bar = Path;
55
| ^^^^ not found in this scope
@@ -10,7 +10,7 @@ LL | use std::path::Path;
1010
|
1111

1212
error[E0425]: cannot find value `A` in this scope
13-
--> $DIR/use_suggestion_placement.rs:27:13
13+
--> $DIR/use_suggestion_placement.rs:23:13
1414
|
1515
LL | let _ = A;
1616
| ^ not found in this scope
@@ -21,7 +21,7 @@ LL | use m::A;
2121
|
2222

2323
error[E0412]: cannot find type `HashMap` in this scope
24-
--> $DIR/use_suggestion_placement.rs:32:23
24+
--> $DIR/use_suggestion_placement.rs:28:23
2525
|
2626
LL | type Dict<K, V> = HashMap<K, V>;
2727
| ^^^^^^^ not found in this scope

0 commit comments

Comments
 (0)