Skip to content

Commit 7a1b01e

Browse files
authored
Rollup merge of #80599 - lqd:issue_805889, r=varkor
`const_generics_defaults`: don't ICE in the unimplemented parts The thought was that we could use `todo!`s to ensure we wouldn't forget to implement parts of the experimental gate. However, that can also lead to a suboptimal experience for users as shown in #80589 having both the error/warning about the experimental feature, and the ICE. Fixes #80589 r? `@varkor`
2 parents bb70305 + ea0f639 commit 7a1b01e

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

compiler/rustc_ast_pretty/src/pprust/state.rs

-1
Original file line numberDiff line numberDiff line change
@@ -2677,7 +2677,6 @@ impl<'a> State<'a> {
26772677
s.print_type_bounds(":", &param.bounds);
26782678
if let Some(ref _default) = default {
26792679
// FIXME(const_generics_defaults): print the `default` value here
2680-
todo!();
26812680
}
26822681
}
26832682
}

compiler/rustc_hir_pretty/src/lib.rs

-1
Original file line numberDiff line numberDiff line change
@@ -2210,7 +2210,6 @@ impl<'a> State<'a> {
22102210
self.print_type(ty);
22112211
if let Some(ref _default) = default {
22122212
// FIXME(const_generics_defaults): print the `default` value here
2213-
todo!();
22142213
}
22152214
}
22162215
}

compiler/rustc_save_analysis/src/sig.rs

-1
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,6 @@ impl<'hir> Sig for hir::Generics<'hir> {
619619
param_text.push_str(&ty_to_string(&ty));
620620
if let Some(ref _default) = default {
621621
// FIXME(const_generics_defaults): push the `default` value here
622-
todo!();
623622
}
624623
}
625624
if !param.bounds.is_empty() {

0 commit comments

Comments
 (0)