Skip to content

Commit 9384de7

Browse files
debuginfo: Add comment on is_local_to_unit parameter.
1 parent d35fff8 commit 9384de7

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/librustc/middle/trans/debuginfo.rs

+7
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,13 @@ pub fn create_function_debug_context(cx: &mut CrateContext,
690690

691691
// Clang sets this parameter to the opening brace of the function's block, so let's do this too.
692692
let scope_line = span_start(cx, top_level_block.span).line;
693+
694+
// The is_local_to_unit flag indicates whether a function is local to the current compilation
695+
// unit (i.e. if it is *static* in the C-sense). The *reachable* set should provide a good
696+
// approximation of this, as it contains everything that might leak out of the current crate
697+
// (by being externally visible or by being inlined into something externally visible). It might
698+
// better to use the `exported_items` set from `driver::CrateAnalysis` in the future, but (atm)
699+
// this set is not available in the translation pass.
693700
let is_local_to_unit = !cx.reachable.contains(&fn_ast_id);
694701

695702
let fn_metadata = function_name.with_c_str(|function_name| {

0 commit comments

Comments
 (0)