Remove the explicit branch hint from const_panic

Author: saethlin

library/core/src/panic.rs

@@ -195,7 +195,7 @@ pub macro const_panic {
 #[doc(hidden)]
 pub macro const_assert {
     ($condition: expr, $const_msg:literal, $runtime_msg:literal, $($arg:tt)*) => {{
-        if !$crate::intrinsics::likely($condition) {
+        if !($condition) {
             $crate::panic::const_panic!($const_msg, $runtime_msg, $($arg)*)
         }
     }}

tests/codegen-llvm/intrinsics/likely_const_assert.rs

@@ -0,0 +1,18 @@
+//@ compile-flags: -Copt-level=3
+#![crate_type = "lib"]
+#![feature(panic_internals, rustc_allow_const_fn_unstable, const_eval_select, core_intrinsics)]
+
+#[no_mangle]
+pub fn test_assert(x: bool) {
+    core::panic::const_assert!(x, "", "",);
+}
+
+// check that assert! emits branch weights
+
+// CHECK-LABEL: @test_assert(
+// CHECK: br i1 %x, label %bb2, label %bb1, !prof ![[NUM:[0-9]+]]
+// CHECK: bb1:
+// CHECK: panic
+// CHECK: bb2:
+// CHECK: ret void
+// CHECK: ![[NUM]] = !{!"branch_weights", {{(!"expected", )?}}i32 2000, i32 1}