Skip to content

Commit ddd771e

Browse files
RalfJungRalfJung
committed
rustc_intrinsic: support functions without body; they are implicitly marked as must-be-overridden
1 parent c528b8c commit ddd771e

File tree

78 files changed

+243
-153
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

78 files changed

+243
-153
lines changed

‎compiler/rustc_ast_lowering/src/item.rs

+33-8
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ impl<'hir> LoweringContext<'_, 'hir> {
233233
header: this.lower_fn_header(*header, hir::Safety::Safe),
234234
span: this.lower_span(*fn_sig_span),
235235
};
236-
hir::ItemKind::Fn(sig, generics, body_id)
236+
hir::ItemKind::Fn { sig, generics, body: body_id, has_body: body.is_some() }
237237
})
238238
}
239239
ItemKind::Mod(_, mod_kind) => match mod_kind {
@@ -435,11 +435,12 @@ impl<'hir> LoweringContext<'_, 'hir> {
435435
}
436436
ItemKind::Delegation(box delegation) => {
437437
let delegation_results = self.lower_delegation(delegation, id);
438-
hir::ItemKind::Fn(
439-
delegation_results.sig,
440-
delegation_results.generics,
441-
delegation_results.body_id,
442-
)
438+
hir::ItemKind::Fn {
439+
sig: delegation_results.sig,
440+
generics: delegation_results.generics,
441+
body: delegation_results.body_id,
442+
has_body: true,
443+
}
443444
}
444445
ItemKind::MacCall(..) | ItemKind::DelegationMac(..) => {
445446
panic!("macros should have been expanded by now")
@@ -1066,7 +1067,25 @@ impl<'hir> LoweringContext<'_, 'hir> {
10661067
fn lower_block_expr_opt(&mut self, span: Span, block: Option<&Block>) -> hir::Expr<'hir> {
10671068
match block {
10681069
Some(block) => self.lower_block_expr(block),
1069-
None => self.expr_err(span, self.dcx().has_errors().unwrap()),
1070+
None => {
1071+
// Generate a fake body of `loop {}` so that the rest of the compiler
1072+
// does not crash due to the function having no body.
1073+
let empty_block = hir::Block {
1074+
hir_id: self.next_id(),
1075+
stmts: &[],
1076+
expr: None,
1077+
rules: hir::BlockCheckMode::DefaultBlock,
1078+
span,
1079+
targeted_by_break: false,
1080+
};
1081+
let loop_ = hir::ExprKind::Loop(
1082+
self.arena.alloc(empty_block),
1083+
None,
1084+
hir::LoopSource::Loop,
1085+
span,
1086+
);
1087+
hir::Expr { hir_id: self.next_id(), kind: loop_, span }
1088+
}
10701089
}
10711090
}
10721091

@@ -1090,9 +1109,15 @@ impl<'hir> LoweringContext<'_, 'hir> {
10901109
coroutine_kind: Option<CoroutineKind>,
10911110
body: Option<&Block>,
10921111
) -> hir::BodyId {
1093-
let (Some(coroutine_kind), Some(body)) = (coroutine_kind, body) else {
1112+
let Some(coroutine_kind) = coroutine_kind else {
1113+
// Normal case: not a coroutine.
10941114
return self.lower_fn_body_block(span, decl, body);
10951115
};
1116+
let Some(body) = body else {
1117+
// Coroutine without a body... always an error.
1118+
return self
1119+
.lower_fn_body(decl, |this| this.expr_err(span, this.dcx().has_errors().unwrap()));
1120+
};
10961121
self.lower_body(|this| {
10971122
let (parameters, expr) = this.lower_coroutine_body_with_moved_arguments(
10981123
decl,

‎compiler/rustc_ast_passes/src/ast_validation.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -920,7 +920,9 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
920920
ItemKind::Fn(box Fn { defaultness, sig, generics, body }) => {
921921
self.check_defaultness(item.span, *defaultness);
922922

923-
if body.is_none() {
923+
let is_intrinsic =
924+
item.attrs.iter().any(|a| a.name_or_empty() == sym::rustc_intrinsic);
925+
if body.is_none() && !is_intrinsic {
924926
self.dcx().emit_err(errors::FnWithoutBody {
925927
span: item.span,
926928
replace_span: self.ending_semi_or_hi(item.span),

‎compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs

+6-2
Original file line numberDiff line numberDiff line change
@@ -981,7 +981,9 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {
981981

982982
let arg = match hir.get_if_local(callee_def_id) {
983983
Some(
984-
hir::Node::Item(hir::Item { ident, kind: hir::ItemKind::Fn(sig, ..), .. })
984+
hir::Node::Item(hir::Item {
985+
ident, kind: hir::ItemKind::Fn { sig, .. }, ..
986+
})
985987
| hir::Node::TraitItem(hir::TraitItem {
986988
ident,
987989
kind: hir::TraitItemKind::Fn(sig, _),
@@ -1020,7 +1022,9 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {
10201022
// ...otherwise we are probably in the tail expression of the function, point at the
10211023
// return type.
10221024
match self.infcx.tcx.hir_node_by_def_id(hir.get_parent_item(fn_call_id).def_id) {
1023-
hir::Node::Item(hir::Item { ident, kind: hir::ItemKind::Fn(sig, ..), .. })
1025+
hir::Node::Item(hir::Item {
1026+
ident, kind: hir::ItemKind::Fn { sig, .. }, ..
1027+
})
10241028
| hir::Node::TraitItem(hir::TraitItem {
10251029
ident,
10261030
kind: hir::TraitItemKind::Fn(sig, _),

‎compiler/rustc_const_eval/src/interpret/call.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,8 @@ impl<'tcx, M: Machine<'tcx>> InterpCx<'tcx, M> {
566566
| ty::InstanceKind::ThreadLocalShim(..)
567567
| ty::InstanceKind::AsyncDropGlueCtorShim(..)
568568
| ty::InstanceKind::Item(_) => {
569-
// We need MIR for this fn
569+
// We need MIR for this fn.
570+
// Note that this can be an intrinsic, if we are executing its fallback body.
570571
let Some((body, instance)) = M::find_mir_or_eval_fn(
571572
self,
572573
instance,

‎compiler/rustc_hir/src/hir.rs

+19-11
Original file line numberDiff line numberDiff line change
@@ -3640,7 +3640,7 @@ impl<'hir> Item<'hir> {
36403640
ItemKind::Const(ty, generics, body), (ty, generics, *body);
36413641

36423642
expect_fn, (&FnSig<'hir>, &'hir Generics<'hir>, BodyId),
3643-
ItemKind::Fn(sig, generics, body), (sig, generics, *body);
3643+
ItemKind::Fn { sig, generics, body, .. }, (sig, generics, *body);
36443644

36453645
expect_macro, (&ast::MacroDef, MacroKind), ItemKind::Macro(def, mk), (def, *mk);
36463646

@@ -3768,7 +3768,15 @@ pub enum ItemKind<'hir> {
37683768
/// A `const` item.
37693769
Const(&'hir Ty<'hir>, &'hir Generics<'hir>, BodyId),
37703770
/// A function declaration.
3771-
Fn(FnSig<'hir>, &'hir Generics<'hir>, BodyId),
3771+
Fn {
3772+
sig: FnSig<'hir>,
3773+
generics: &'hir Generics<'hir>,
3774+
body: BodyId,
3775+
/// Whether this function actually has a body.
3776+
/// For functions without a body, `body` is synthesized (to avoid ICEs all over the
3777+
/// compiler), but that code should never be translated.
3778+
has_body: bool,
3779+
},
37723780
/// A MBE macro definition (`macro_rules!` or `macro`).
37733781
Macro(&'hir ast::MacroDef, MacroKind),
37743782
/// A module.
@@ -3819,7 +3827,7 @@ pub struct Impl<'hir> {
38193827
impl ItemKind<'_> {
38203828
pub fn generics(&self) -> Option<&Generics<'_>> {
38213829
Some(match *self {
3822-
ItemKind::Fn(_, ref generics, _)
3830+
ItemKind::Fn { ref generics, .. }
38233831
| ItemKind::TyAlias(_, ref generics)
38243832
| ItemKind::Const(_, ref generics, _)
38253833
| ItemKind::Enum(_, ref generics)
@@ -3838,7 +3846,7 @@ impl ItemKind<'_> {
38383846
ItemKind::Use(..) => "`use` import",
38393847
ItemKind::Static(..) => "static item",
38403848
ItemKind::Const(..) => "constant item",
3841-
ItemKind::Fn(..) => "function",
3849+
ItemKind::Fn { .. } => "function",
38423850
ItemKind::Macro(..) => "macro",
38433851
ItemKind::Mod(..) => "module",
38443852
ItemKind::ForeignMod { .. } => "extern block",
@@ -4004,7 +4012,7 @@ impl<'hir> OwnerNode<'hir> {
40044012
match self {
40054013
OwnerNode::TraitItem(TraitItem { kind: TraitItemKind::Fn(fn_sig, _), .. })
40064014
| OwnerNode::ImplItem(ImplItem { kind: ImplItemKind::Fn(fn_sig, _), .. })
4007-
| OwnerNode::Item(Item { kind: ItemKind::Fn(fn_sig, _, _), .. })
4015+
| OwnerNode::Item(Item { kind: ItemKind::Fn { sig: fn_sig, .. }, .. })
40084016
| OwnerNode::ForeignItem(ForeignItem {
40094017
kind: ForeignItemKind::Fn(fn_sig, _, _), ..
40104018
}) => Some(fn_sig),
@@ -4016,7 +4024,7 @@ impl<'hir> OwnerNode<'hir> {
40164024
match self {
40174025
OwnerNode::TraitItem(TraitItem { kind: TraitItemKind::Fn(fn_sig, _), .. })
40184026
| OwnerNode::ImplItem(ImplItem { kind: ImplItemKind::Fn(fn_sig, _), .. })
4019-
| OwnerNode::Item(Item { kind: ItemKind::Fn(fn_sig, _, _), .. })
4027+
| OwnerNode::Item(Item { kind: ItemKind::Fn { sig: fn_sig, .. }, .. })
40204028
| OwnerNode::ForeignItem(ForeignItem {
40214029
kind: ForeignItemKind::Fn(fn_sig, _, _), ..
40224030
}) => Some(fn_sig.decl),
@@ -4030,7 +4038,7 @@ impl<'hir> OwnerNode<'hir> {
40304038
kind:
40314039
ItemKind::Static(_, _, body)
40324040
| ItemKind::Const(_, _, body)
4033-
| ItemKind::Fn(_, _, body),
4041+
| ItemKind::Fn { body, .. },
40344042
..
40354043
})
40364044
| OwnerNode::TraitItem(TraitItem {
@@ -4206,7 +4214,7 @@ impl<'hir> Node<'hir> {
42064214
match self {
42074215
Node::TraitItem(TraitItem { kind: TraitItemKind::Fn(fn_sig, _), .. })
42084216
| Node::ImplItem(ImplItem { kind: ImplItemKind::Fn(fn_sig, _), .. })
4209-
| Node::Item(Item { kind: ItemKind::Fn(fn_sig, _, _), .. })
4217+
| Node::Item(Item { kind: ItemKind::Fn { sig: fn_sig, .. }, .. })
42104218
| Node::ForeignItem(ForeignItem { kind: ForeignItemKind::Fn(fn_sig, _, _), .. }) => {
42114219
Some(fn_sig.decl)
42124220
}
@@ -4236,7 +4244,7 @@ impl<'hir> Node<'hir> {
42364244
match self {
42374245
Node::TraitItem(TraitItem { kind: TraitItemKind::Fn(fn_sig, _), .. })
42384246
| Node::ImplItem(ImplItem { kind: ImplItemKind::Fn(fn_sig, _), .. })
4239-
| Node::Item(Item { kind: ItemKind::Fn(fn_sig, _, _), .. })
4247+
| Node::Item(Item { kind: ItemKind::Fn { sig: fn_sig, .. }, .. })
42404248
| Node::ForeignItem(ForeignItem { kind: ForeignItemKind::Fn(fn_sig, _, _), .. }) => {
42414249
Some(fn_sig)
42424250
}
@@ -4281,7 +4289,7 @@ impl<'hir> Node<'hir> {
42814289
Node::Item(Item {
42824290
owner_id,
42834291
kind:
4284-
ItemKind::Const(_, _, body) | ItemKind::Static(.., body) | ItemKind::Fn(.., body),
4292+
ItemKind::Const(_, _, body) | ItemKind::Static(.., body) | ItemKind::Fn { body, .. },
42854293
..
42864294
})
42874295
| Node::TraitItem(TraitItem {
@@ -4338,7 +4346,7 @@ impl<'hir> Node<'hir> {
43384346
pub fn fn_kind(self) -> Option<FnKind<'hir>> {
43394347
match self {
43404348
Node::Item(i) => match i.kind {
4341-
ItemKind::Fn(ref sig, ref generics, _) => {
4349+
ItemKind::Fn { sig, generics, .. } => {
43424350
Some(FnKind::ItemFn(i.ident, generics, sig.header))
43434351
}
43444352
_ => None,

‎compiler/rustc_hir/src/intravisit.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ pub fn walk_item<'v, V: Visitor<'v>>(visitor: &mut V, item: &'v Item<'v>) -> V::
509509
try_visit!(visitor.visit_generics(generics));
510510
try_visit!(visitor.visit_nested_body(body));
511511
}
512-
ItemKind::Fn(ref sig, ref generics, body_id) => {
512+
ItemKind::Fn { sig, generics, body: body_id, .. } => {
513513
try_visit!(visitor.visit_id(item.hir_id()));
514514
try_visit!(visitor.visit_fn(
515515
FnKind::ItemFn(item.ident, generics, sig.header),

‎compiler/rustc_hir/src/target.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ impl Target {
106106
ItemKind::Use(..) => Target::Use,
107107
ItemKind::Static { .. } => Target::Static,
108108
ItemKind::Const(..) => Target::Const,
109-
ItemKind::Fn(..) => Target::Fn,
109+
ItemKind::Fn { .. } => Target::Fn,
110110
ItemKind::Macro(..) => Target::MacroDef,
111111
ItemKind::Mod(..) => Target::Mod,
112112
ItemKind::ForeignMod { .. } => Target::ForeignMod,

‎compiler/rustc_hir_analysis/src/check/entry.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ fn check_main_fn_ty(tcx: TyCtxt<'_>, main_def_id: DefId) {
4444
return None;
4545
}
4646
match tcx.hir_node_by_def_id(def_id.expect_local()) {
47-
Node::Item(hir::Item { kind: hir::ItemKind::Fn(_, generics, _), .. }) => {
47+
Node::Item(hir::Item { kind: hir::ItemKind::Fn { generics, .. }, .. }) => {
4848
generics.params.is_empty().not().then_some(generics.span)
4949
}
5050
_ => {
@@ -58,7 +58,7 @@ fn check_main_fn_ty(tcx: TyCtxt<'_>, main_def_id: DefId) {
5858
return None;
5959
}
6060
match tcx.hir_node_by_def_id(def_id.expect_local()) {
61-
Node::Item(hir::Item { kind: hir::ItemKind::Fn(_, generics, _), .. }) => {
61+
Node::Item(hir::Item { kind: hir::ItemKind::Fn { generics, .. }, .. }) => {
6262
Some(generics.where_clause_span)
6363
}
6464
_ => {
@@ -79,7 +79,7 @@ fn check_main_fn_ty(tcx: TyCtxt<'_>, main_def_id: DefId) {
7979
return None;
8080
}
8181
match tcx.hir_node_by_def_id(def_id.expect_local()) {
82-
Node::Item(hir::Item { kind: hir::ItemKind::Fn(fn_sig, _, _), .. }) => {
82+
Node::Item(hir::Item { kind: hir::ItemKind::Fn { sig: fn_sig, .. }, .. }) => {
8383
Some(fn_sig.decl.output.span())
8484
}
8585
_ => {
@@ -201,7 +201,7 @@ fn check_start_fn_ty(tcx: TyCtxt<'_>, start_def_id: DefId) {
201201
match start_t.kind() {
202202
ty::FnDef(..) => {
203203
if let Node::Item(it) = tcx.hir_node(start_id) {
204-
if let hir::ItemKind::Fn(sig, generics, _) = &it.kind {
204+
if let hir::ItemKind::Fn { sig, generics, .. } = &it.kind {
205205
let mut error = false;
206206
if !generics.params.is_empty() {
207207
tcx.dcx().emit_err(errors::StartFunctionParameters { span: generics.span });

‎compiler/rustc_hir_analysis/src/check/intrinsic.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ fn equate_intrinsic_type<'tcx>(
2626
sig: ty::PolyFnSig<'tcx>,
2727
) {
2828
let (generics, span) = match tcx.hir_node_by_def_id(def_id) {
29-
hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn(_, generics, _), .. })
29+
hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn { generics, .. }, .. })
3030
| hir::Node::ForeignItem(hir::ForeignItem {
3131
kind: hir::ForeignItemKind::Fn(_, _, generics),
3232
..

‎compiler/rustc_hir_analysis/src/check/wfcheck.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ fn check_item<'tcx>(tcx: TyCtxt<'tcx>, item: &'tcx hir::Item<'tcx>) -> Result<()
293293
}
294294
res
295295
}
296-
hir::ItemKind::Fn(ref sig, ..) => {
296+
hir::ItemKind::Fn { sig, .. } => {
297297
check_item_fn(tcx, def_id, item.ident, item.span, sig.decl)
298298
}
299299
hir::ItemKind::Static(ty, ..) => {

‎compiler/rustc_hir_analysis/src/collect.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -788,7 +788,7 @@ fn lower_item(tcx: TyCtxt<'_>, item_id: hir::ItemId) {
788788
}
789789
}
790790

791-
hir::ItemKind::Fn(..) => {
791+
hir::ItemKind::Fn { .. } => {
792792
tcx.ensure().generics_of(def_id);
793793
tcx.ensure().type_of(def_id);
794794
tcx.ensure().predicates_of(def_id);
@@ -1297,7 +1297,7 @@ fn fn_sig(tcx: TyCtxt<'_>, def_id: LocalDefId) -> ty::EarlyBinder<'_, ty::PolyFn
12971297
generics,
12981298
..
12991299
})
1300-
| Item(hir::Item { kind: ItemKind::Fn(sig, generics, _), .. }) => {
1300+
| Item(hir::Item { kind: ItemKind::Fn { sig, generics, .. }, .. }) => {
13011301
lower_fn_sig_recovering_infer_ret_ty(&icx, sig, generics, def_id)
13021302
}
13031303

‎compiler/rustc_hir_analysis/src/collect/predicates_of.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -969,7 +969,7 @@ pub(super) fn const_conditions<'tcx>(
969969
{
970970
Node::Item(item) => match item.kind {
971971
hir::ItemKind::Impl(impl_) => (impl_.generics, None, false),
972-
hir::ItemKind::Fn(_, generics, _) => (generics, None, false),
972+
hir::ItemKind::Fn { generics, .. } => (generics, None, false),
973973
hir::ItemKind::Trait(_, _, generics, supertraits, _) => {
974974
(generics, Some((item.owner_id.def_id, supertraits)), false)
975975
}

‎compiler/rustc_hir_analysis/src/collect/resolve_bound_vars.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ impl<'a, 'tcx> Visitor<'tcx> for BoundVarContext<'a, 'tcx> {
660660
_ => {}
661661
}
662662
match item.kind {
663-
hir::ItemKind::Fn(_, generics, _) => {
663+
hir::ItemKind::Fn { generics, .. } => {
664664
self.visit_early_late(item.hir_id(), generics, |this| {
665665
intravisit::walk_item(this, item);
666666
});
@@ -1379,7 +1379,7 @@ impl<'a, 'tcx> BoundVarContext<'a, 'tcx> {
13791379
} else if let Some(body_id) = outermost_body {
13801380
let fn_id = self.tcx.hir().body_owner(body_id);
13811381
match self.tcx.hir_node(fn_id) {
1382-
Node::Item(hir::Item { owner_id, kind: hir::ItemKind::Fn(..), .. })
1382+
Node::Item(hir::Item { owner_id, kind: hir::ItemKind::Fn { .. }, .. })
13831383
| Node::TraitItem(hir::TraitItem {
13841384
owner_id,
13851385
kind: hir::TraitItemKind::Fn(..),

‎compiler/rustc_hir_analysis/src/collect/type_of.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ pub(super) fn type_of(tcx: TyCtxt<'_>, def_id: LocalDefId) -> ty::EarlyBinder<'_
293293
}
294294
_ => icx.lower_ty(*self_ty),
295295
},
296-
ItemKind::Fn(..) => {
296+
ItemKind::Fn { .. } => {
297297
let args = ty::GenericArgs::identity_for_item(tcx, def_id);
298298
Ty::new_fn_def(tcx, def_id.to_def_id(), args)
299299
}

‎compiler/rustc_hir_analysis/src/hir_ty_lowering/lint.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -189,9 +189,9 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
189189
// 2. Functions inside trait blocks
190190
// 3. Functions inside impl blocks
191191
let (sig, generics) = match tcx.hir_node_by_def_id(parent_id) {
192-
hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn(sig, generics, _), .. }) => {
193-
(sig, generics)
194-
}
192+
hir::Node::Item(hir::Item {
193+
kind: hir::ItemKind::Fn { sig, generics, .. }, ..
194+
}) => (sig, generics),
195195
hir::Node::TraitItem(hir::TraitItem {
196196
kind: hir::TraitItemKind::Fn(sig, _),
197197
generics,

‎compiler/rustc_hir_pretty/src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ impl<'a> State<'a> {
634634
self.word(";");
635635
self.end(); // end the outer cbox
636636
}
637-
hir::ItemKind::Fn(ref sig, generics, body) => {
637+
hir::ItemKind::Fn { sig, generics, body, .. } => {
638638
self.head("");
639639
self.print_fn(
640640
sig.decl,

‎compiler/rustc_hir_typeck/src/_match.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
391391
if let hir::Node::Block(block) = node {
392392
// check that the body's parent is an fn
393393
let parent = self.tcx.parent_hir_node(self.tcx.parent_hir_id(block.hir_id));
394-
if let (Some(expr), hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn(..), .. })) =
394+
if let (Some(expr), hir::Node::Item(hir::Item { kind: hir::ItemKind::Fn { .. }, .. })) =
395395
(&block.expr, parent)
396396
{
397397
// check that the `if` expr without `else` is the fn body's expr

‎compiler/rustc_hir_typeck/src/callee.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
705705
for id in self.tcx.hir().items() {
706706
if let Some(node) = self.tcx.hir().get_if_local(id.owner_id.into())
707707
&& let hir::Node::Item(item) = node
708-
&& let hir::ItemKind::Fn(..) = item.kind
708+
&& let hir::ItemKind::Fn { .. } = item.kind
709709
&& item.ident.name == segment.ident.name
710710
{
711711
err.span_label(

‎compiler/rustc_hir_typeck/src/expr.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,9 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
11271127
let encl_item_id = self.tcx.hir().get_parent_item(expr.hir_id);
11281128

11291129
if let hir::Node::Item(hir::Item {
1130-
kind: hir::ItemKind::Fn(..), span: encl_fn_span, ..
1130+
kind: hir::ItemKind::Fn { .. },
1131+
span: encl_fn_span,
1132+
..
11311133
})
11321134
| hir::Node::TraitItem(hir::TraitItem {
11331135
kind: hir::TraitItemKind::Fn(_, hir::TraitFn::Provided(_)),

0 commit comments

Comments
 (0)