some nits before squash

Author: Kivooeo

tests/ui/lifetimes/rvalue-lifetime-for-loop.rs renamed to tests/ui/drop/for-expr-temporary-drop-scope.rs

@@ -1,20 +1,20 @@
 //! Trait objects only allow access to methods defined in the trait.
 
 trait MyTrait {
-    fn do_something(&mut self);
+    fn trait_method(&mut self);
 }
 
 struct ImplType;
 
 impl MyTrait for ImplType {
-    fn do_something(&mut self) {}
+    fn trait_method(&mut self) {}
 }
 
 impl ImplType {
-    fn extra_method(&mut self) {}
+    fn struct_impl_method(&mut self) {}
 }
 
 fn main() {
     let obj: Box<dyn MyTrait> = Box::new(ImplType);
-    obj.extra_method(); //~ ERROR no method named `extra_method` found
+    obj.struct_impl_method(); //~ ERROR no method named `struct_impl_method` found
 }

tests/ui/privacy/trait-object-method-error.rs

@@ -1,8 +1,14 @@
-error[E0599]: no method named `extra_method` found for struct `Box<dyn MyTrait>` in the current scope
+error[E0599]: no method named `struct_impl_method` found for struct `Box<dyn MyTrait>` in the current scope
   --> $DIR/trait-object-method-error.rs:19:9
    |
-LL |     obj.extra_method();
-   |         ^^^^^^^^^^^^ method not found in `Box<dyn MyTrait>`
+LL |     obj.struct_impl_method();
+   |         ^^^^^^^^^^^^^^^^^^
+   |
+help: there is a method `trait_method` with a similar name
+   |
+LL -     obj.struct_impl_method();
+LL +     obj.trait_method();
+   |
 
 error: aborting due to 1 previous error
 

tests/ui/privacy/trait-object-method-error.stderr

@@ -1,12 +1,12 @@
 //! Trait impls must define all required methods.
 
 trait MyTrait {
-    fn do_something(&self);
+    fn trait_method(&self);
 }
 
 struct ImplType;
 
-impl MyTrait for ImplType {} //~ ERROR not all trait items implemented, missing: `do_something`
+impl MyTrait for ImplType {} //~ ERROR not all trait items implemented, missing: `trait_method`
 
 fn main() {
     let _ = ImplType;

tests/ui/traits/trait-impl-missing-method.rs

@@ -1,11 +1,11 @@
-error[E0046]: not all trait items implemented, missing: `do_something`
+error[E0046]: not all trait items implemented, missing: `trait_method`
   --> $DIR/trait-impl-missing-method.rs:9:1
    |
-LL |     fn do_something(&self);
-   |     ----------------------- `do_something` from trait
+LL |     fn trait_method(&self);
+   |     ----------------------- `trait_method` from trait
 ...
 LL | impl MyTrait for ImplType {}
-   | ^^^^^^^^^^^^^^^^^^^^^^^^^ missing `do_something` in implementation
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^ missing `trait_method` in implementation
 
 error: aborting due to 1 previous error