Skip to content

Commit eff87bc

Browse files
committed
auto merge of #16543 : huonw/rust/deprecated-btree, r=alexcrichton
This is very half-baked at the moment and very inefficient, e.g. inappropriate use of by-value `self` (and thus being forced into an overuse of `clone`). People get the wrong impression about Rust when using it, e.g. that Rust cannot express what other languages can because the implementation is inefficient: https://news.ycombinator.com/item?id=8187831 .
2 parents a12a4dd + 7b141ad commit eff87bc

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/libcollections/btree.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,13 @@
1111
// btree.rs
1212
//
1313

14+
// NB. this is not deprecated for removal, just deprecating the
15+
// current implementation. If the major pain-points are addressed
16+
// (overuse of by-value self and .clone), this can be removed.
17+
#![deprecated = "the current implementation is extremely inefficient, \
18+
prefer a HashMap, TreeMap or TrieMap"]
19+
#![allow(deprecated)]
20+
1421
//! Starting implementation of a btree for rust.
1522
//! Structure inspired by github user davidhalperin's gist.
1623

0 commit comments

Comments
 (0)