Skip to content

Commit f293ea2

Browse files
committed
Remove the deprecated box(PLACE) syntax.
1 parent 07ca1ab commit f293ea2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+117
-282
lines changed

src/liballoc/boxed.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,10 @@ use core::raw::{TraitObject};
8080
/// use std::boxed::HEAP;
8181
///
8282
/// fn main() {
83-
/// let foo = box(HEAP) 5;
83+
/// let foo: Box<i32> = in HEAP { 5 };
8484
/// let foo = box 5;
8585
/// }
8686
/// ```
87-
#[lang = "exchange_heap"]
8887
#[unstable(feature = "box_heap",
8988
reason = "may be renamed; uncertain about custom allocator design",
9089
issue = "27779")]

src/librustc/middle/cfg/construct.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,13 +344,12 @@ impl<'a, 'tcx> CFGBuilder<'a, 'tcx> {
344344
self.straightline(expr, pred, [r, l].iter().map(|&e| &**e))
345345
}
346346

347-
hir::ExprBox(Some(ref l), ref r) |
348347
hir::ExprIndex(ref l, ref r) |
349348
hir::ExprBinary(_, ref l, ref r) => { // NB: && and || handled earlier
350349
self.straightline(expr, pred, [l, r].iter().map(|&e| &**e))
351350
}
352351

353-
hir::ExprBox(None, ref e) |
352+
hir::ExprBox(ref e) |
354353
hir::ExprAddrOf(_, ref e) |
355354
hir::ExprCast(ref e, _) |
356355
hir::ExprUnary(_, ref e) |

src/librustc/middle/check_const.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -568,8 +568,7 @@ fn check_expr<'a, 'tcx>(v: &mut CheckCrateVisitor<'a, 'tcx>,
568568
"user-defined operators are not allowed in {}s", v.msg());
569569
}
570570
}
571-
hir::ExprBox(..) |
572-
hir::ExprUnary(hir::UnUniq, _) => {
571+
hir::ExprBox(_) => {
573572
v.add_qualif(ConstQualif::NOT_CONST);
574573
if v.mode != Mode::Var {
575574
span_err!(v.tcx.sess, e.span, E0010,

src/librustc/middle/expr_use_visitor.rs

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -280,13 +280,11 @@ impl<'d,'t,'a,'tcx> ExprUseVisitor<'d,'t,'a,'tcx> {
280280
typer: &'t infer::InferCtxt<'a, 'tcx>)
281281
-> ExprUseVisitor<'d,'t,'a,'tcx>
282282
{
283-
let result = ExprUseVisitor {
283+
ExprUseVisitor {
284284
typer: typer,
285285
mc: mc::MemCategorizationContext::new(typer),
286286
delegate: delegate,
287-
};
288-
289-
result
287+
}
290288
}
291289

292290
pub fn walk_fn(&mut self,
@@ -544,17 +542,8 @@ impl<'d,'t,'a,'tcx> ExprUseVisitor<'d,'t,'a,'tcx> {
544542
self.walk_captures(expr)
545543
}
546544

547-
hir::ExprBox(ref place, ref base) => {
548-
match *place {
549-
Some(ref place) => self.consume_expr(&**place),
550-
None => {}
551-
}
545+
hir::ExprBox(ref base) => {
552546
self.consume_expr(&**base);
553-
if place.is_some() {
554-
self.tcx().sess.span_bug(
555-
expr.span,
556-
"box with explicit place remains after expansion");
557-
}
558547
}
559548
}
560549
}

src/librustc/middle/lang_items.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,6 @@ lets_do_this! {
341341
EhUnwindResumeLangItem, "eh_unwind_resume", eh_unwind_resume;
342342
MSVCTryFilterLangItem, "msvc_try_filter", msvc_try_filter;
343343

344-
ExchangeHeapLangItem, "exchange_heap", exchange_heap;
345344
OwnedBoxLangItem, "owned_box", owned_box;
346345

347346
PhantomDataItem, "phantom_data", phantom_data;

src/librustc/middle/liveness.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1147,8 +1147,7 @@ impl<'a, 'tcx> Liveness<'a, 'tcx> {
11471147
}
11481148

11491149
hir::ExprIndex(ref l, ref r) |
1150-
hir::ExprBinary(_, ref l, ref r) |
1151-
hir::ExprBox(Some(ref l), ref r) => {
1150+
hir::ExprBinary(_, ref l, ref r) => {
11521151
let r_succ = self.propagate_through_expr(&**r, succ);
11531152
self.propagate_through_expr(&**l, r_succ)
11541153
}
@@ -1158,7 +1157,7 @@ impl<'a, 'tcx> Liveness<'a, 'tcx> {
11581157
e1.as_ref().map_or(succ, |e| self.propagate_through_expr(&**e, succ))
11591158
}
11601159

1161-
hir::ExprBox(None, ref e) |
1160+
hir::ExprBox(ref e) |
11621161
hir::ExprAddrOf(_, ref e) |
11631162
hir::ExprCast(ref e, _) |
11641163
hir::ExprUnary(_, ref e) => {

src/librustc/middle/region.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -994,9 +994,6 @@ fn resolve_local(visitor: &mut RegionResolutionVisitor, local: &hir::Local) {
994994
visitor, &**subexpr, blk_id);
995995
}
996996
}
997-
hir::ExprUnary(hir::UnUniq, ref subexpr) => {
998-
record_rvalue_scope_if_borrow_expr(visitor, &**subexpr, blk_id);
999-
}
1000997
hir::ExprCast(ref subexpr, _) => {
1001998
record_rvalue_scope_if_borrow_expr(visitor, &**subexpr, blk_id)
1002999
}

src/librustc_front/fold.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,8 +1040,8 @@ pub fn noop_fold_expr<T: Folder>(Expr {id, node, span}: Expr, folder: &mut T) ->
10401040
Expr {
10411041
id: folder.new_id(id),
10421042
node: match node {
1043-
ExprBox(p, e) => {
1044-
ExprBox(p.map(|e|folder.fold_expr(e)), folder.fold_expr(e))
1043+
ExprBox(e) => {
1044+
ExprBox(folder.fold_expr(e))
10451045
}
10461046
ExprVec(exprs) => {
10471047
ExprVec(exprs.move_map(|x| folder.fold_expr(x)))

src/librustc_front/hir.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -491,8 +491,6 @@ pub type BinOp = Spanned<BinOp_>;
491491

492492
#[derive(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Debug, Copy)]
493493
pub enum UnOp {
494-
/// The `box` operator
495-
UnUniq,
496494
/// The `*` operator for dereferencing
497495
UnDeref,
498496
/// The `!` operator for logical inversion
@@ -595,8 +593,8 @@ impl fmt::Debug for Expr {
595593

596594
#[derive(Clone, PartialEq, Eq, RustcEncodable, RustcDecodable, Hash, Debug)]
597595
pub enum Expr_ {
598-
/// First expr is the place; second expr is the value.
599-
ExprBox(Option<P<Expr>>, P<Expr>),
596+
/// A `box x` expression.
597+
ExprBox(P<Expr>),
600598
/// An array (`[a, b, c, d]`)
601599
ExprVec(Vec<P<Expr>>),
602600
/// A function call

src/librustc_front/lowering.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,6 @@ pub fn lower_constness(c: Constness) -> hir::Constness {
605605

606606
pub fn lower_unop(u: UnOp) -> hir::UnOp {
607607
match u {
608-
UnUniq => hir::UnUniq,
609608
UnDeref => hir::UnDeref,
610609
UnNot => hir::UnNot,
611610
UnNeg => hir::UnNeg,
@@ -694,8 +693,8 @@ pub fn lower_expr(e: &Expr) -> P<hir::Expr> {
694693
P(hir::Expr {
695694
id: e.id,
696695
node: match e.node {
697-
ExprBox(ref p, ref e) => {
698-
hir::ExprBox(p.as_ref().map(|e| lower_expr(e)), lower_expr(e))
696+
ExprBox(ref e) => {
697+
hir::ExprBox(lower_expr(e))
699698
}
700699
ExprVec(ref exprs) => {
701700
hir::ExprVec(exprs.iter().map(|x| lower_expr(x)).collect())
@@ -818,6 +817,7 @@ pub fn lower_expr(e: &Expr) -> P<hir::Expr> {
818817
ExprParen(ref ex) => {
819818
return lower_expr(ex);
820819
}
820+
ExprInPlace(..) |
821821
ExprIfLet(..) |
822822
ExprWhileLet(..) |
823823
ExprForLoop(..) |

0 commit comments

Comments
 (0)