Return a better result from blocks. Closes issue #377

Blocks return in a copy of the result of their ending expression, not the
direct result of the ending expression, as that may be a local variable which
gets zeroed by drop_slot.

Author: brson

src/comp/middle/trans.rs

@@ -6252,6 +6252,9 @@ fn trans_block(&@block_ctxt cx, &ast::block b) -> result {
                     auto cleanup = bind drop_hoisted_ty(_, res_alloca.val,
                                                         r_ty);
                     find_outer_scope_cx(bcx).cleanups += [clean(cleanup)];
+
+                    r = res(bcx, load_if_immediate(bcx,
+                                                   res_alloca.val, r_ty));
                 }
             }
         }

src/test/run-pass/expr-block-slot.rs

@@ -0,0 +1,19 @@
+// xfail-stage0
+
+// Regression test for issue #377
+
+fn main() {
+  auto a = {
+    auto b = tup(3);
+    b
+  };
+
+  assert a._0 == 3;
+
+  auto c = {
+    auto d = rec(v=3);
+    d
+  };
+
+  assert c.v == 3;
+}