Skip to content

Commit ff0b5bc

Browse files
committed
llvm 20: adapt integer comparison tests
The LLVM commit llvm/llvm-project@abf69a1 changed the IR in a few comparison tests: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/30500#01917017-26fe-4a4d-956b-725a2903e5a8 Adapted accordingly.
1 parent 4d7c095 commit ff0b5bc

File tree

2 files changed

+27
-13
lines changed

2 files changed

+27
-13
lines changed

tests/codegen/comparison-operators-2-tuple.rs

+14-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
//@ compile-flags: -C opt-level=1 -Z merge-functions=disabled
22
//@ only-x86_64
3+
//@ revisions: llvm-pre-20 llvm-20
4+
//@[llvm-20]min-llvm-version: 20
5+
//@[llvm-pre-20]ignore-llvm-version: 20 - 99
36

47
#![crate_type = "lib"]
58

@@ -77,11 +80,17 @@ pub fn check_ge_direct(a: TwoTuple, b: TwoTuple) -> bool {
7780
// CHECK-SAME: (i16 noundef %[[A0:.+]], i16 noundef %[[A1:.+]], i16 noundef %[[B0:.+]], i16 noundef %[[B1:.+]])
7881
#[no_mangle]
7982
pub fn check_lt_via_cmp(a: TwoTuple, b: TwoTuple) -> bool {
80-
// CHECK-DAG: %[[EQ:.+]] = icmp eq i16 %[[A0]], %[[B0]]
81-
// CHECK-DAG: %[[CMP0:.+]] = icmp slt i16 %[[A0]], %[[B0]]
82-
// CHECK-DAG: %[[CMP1:.+]] = icmp ult i16 %[[A1]], %[[B1]]
83-
// CHECK: %[[R:.+]] = select i1 %[[EQ]], i1 %[[CMP1]], i1 %[[CMP0]]
84-
// CHECK: ret i1 %[[R]]
83+
// llvm-20-DAG: %[[CMP0:.+]] = tail call noundef range(i8 -1, 2) i8 @llvm.scmp.i8.i16(i16 %[[A0]], i16 %[[B0]])
84+
// llvm-20-DAG: %[[EQ:.+]] = icmp eq i16 %[[A0]], %[[B0]]
85+
// llvm-20-DAG: %[[CMP1:.+]] = tail call range(i8 -1, 2) i8 @llvm.ucmp.i8.i16(i16 %[[A1]], i16 %[[B1]])
86+
// llvm-20: %[[S:.+]] = select i1 %[[EQ]], i8 %[[CMP1]], i8 %[[CMP0]]
87+
// llvm-20: %[[R:.+]] = icmp eq i8 %[[S]], -1
88+
// llvm-20: ret i1 %[[R]]
89+
// llvm-pre-20-DAG: icmp eq i16 %[[A0]], %[[B0]]
90+
// llvm-pre-20-DAG: %[[CMP0:.+]] = icmp slt i16 %[[A0]], %[[B0]]
91+
// llvm-pre-20-DAG: %[[CMP1:.+]] = icmp ult i16 %[[A1]], %[[B1]]
92+
// llvm-pre-20: %[[R:.+]] = select i1 %[[EQ]], i1 %[[CMP1]], i1 %[[CMP0]]
93+
// llvm-pre-20: ret i1 %[[R]]
8594
Ord::cmp(&a, &b).is_lt()
8695
}
8796

tests/codegen/integer-cmp.rs

+13-8
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
// This is test for more optimal Ord implementation for integers.
22
// See <https://github.com/rust-lang/rust/issues/63758> for more info.
33

4+
//@ revisions: llvm-pre-20 llvm-20
5+
//@[llvm-20]min-llvm-version: 20
6+
//@[llvm-pre-20]ignore-llvm-version: 20 - 99
47
//@ compile-flags: -C opt-level=3
58

69
#![crate_type = "lib"]
@@ -10,19 +13,21 @@ use std::cmp::Ordering;
1013
// CHECK-LABEL: @cmp_signed
1114
#[no_mangle]
1215
pub fn cmp_signed(a: i64, b: i64) -> Ordering {
13-
// CHECK: icmp slt
14-
// CHECK: icmp ne
15-
// CHECK: zext i1
16-
// CHECK: select i1
16+
// llvm-20: @llvm.scmp.i8.i64
17+
// llvm-pre-20: icmp slt
18+
// llvm-pre-20: icmp ne
19+
// llvm-pre-20: zext i1
20+
// llvm-pre-20: select i1
1721
a.cmp(&b)
1822
}
1923

2024
// CHECK-LABEL: @cmp_unsigned
2125
#[no_mangle]
2226
pub fn cmp_unsigned(a: u32, b: u32) -> Ordering {
23-
// CHECK: icmp ult
24-
// CHECK: icmp ne
25-
// CHECK: zext i1
26-
// CHECK: select i1
27+
// llvm-20: @llvm.ucmp.i8.i32
28+
// llvm-pre-20: icmp ult
29+
// llvm-pre-20: icmp ne
30+
// llvm-pre-20: zext i1
31+
// llvm-pre-20: select i1
2732
a.cmp(&b)
2833
}

0 commit comments

Comments
 (0)