Skip to content

Misleading comments over methods on TyCtxtEnsure in rustc_middle::mir::interpret::queries #104463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cjgillot opened this issue Nov 15, 2022 · 0 comments
Open

Misleading comments over methods on TyCtxtEnsure in rustc_middle::mir::interpret::queries #104463

cjgillot opened this issue Nov 15, 2022 · 0 comments
Assignees
@cjgillot
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-bug Category: This is a bug.

Comments

@cjgillot
Copy link
Contributor

cjgillot commented Nov 15, 2022 •
edited
Loading

These comments (also the one below) are wrong now -- they talk about the return value of a function that doesn't return anything! I have no idea what is going on here so if someone could make a PR to update the comments, that would be much appreciated. :)

_Originally posted by @RalfJung in #98238 (comment)
@cjgillot cjgillot self-assigned this Nov 15, 2022
@jyn514 jyn514 added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjgillot cjgillot

Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjgillot @jyn514